From 9f4e2bef520929d66fbdadd04bbc06efe0179f6e Mon Sep 17 00:00:00 2001 From: Andy Holmes Date: Tue, 29 Oct 2024 10:52:22 -0700 Subject: [PATCH 1/2] test(asan): drop unnecessary LSan suppressions Many of these have been fixed, or simple don't apply anymore. --- tests/extra/lsan.supp | 36 ------------------------------------ 1 file changed, 36 deletions(-) diff --git a/tests/extra/lsan.supp b/tests/extra/lsan.supp index 619a9a6ebb..06566ca7dc 100644 --- a/tests/extra/lsan.supp +++ b/tests/extra/lsan.supp @@ -4,50 +4,14 @@ # https://gitlab.freedesktop.org/fontconfig/fontconfig/-/issues/77 leak:libfontconfig.so -# https://gitlab.gnome.org/GNOME/gvfs/-/issues/577 -leak:g_daemon_vfs_init - -# https://gitlab.gnome.org/GNOME/libadwaita/-/merge_requests/816 -leak:update_custom_image_snapshot - # https://gitlab.gnome.org/GNOME/evolution-data-server/-/merge_requests/162 leak:e_contact_get_property -# FIXME: Unconfirmed (valent-notifications-plugin) -leak:gtk_media_file_extension_init - # FIXME: Unconfirmed (valent-messages-adapter,valent-sms-device) leak:tracker_sparql_execute_cursor leak:tracker_sparql_execute_update leak:translate_RDFLiteral.lto_priv.0 -# False positives caused by G_TEST_OPTION_ISOLATE_DIRS -leak:g_content_type_set_mime_dirs -leak:g_test_init -leak:test_do_isolate_dirs -leak:adw_init -leak:adw_style_init - -# False positive in a11y stack (TODO: re-check these) -leak:gtk_accessible_attribute_set_new -leak:gtk_accessible_value_alloc -leak:gtk_at_context_create -leak:gtk_test_at_context_new - -# TODO: these only seem to crop up in valent-messages-window.c -leak:libpango-1.0.so -leak:libpangocairo-1.0.so - -# librsvg -leak:librsvg-2.so - -# GLib -leak:g_quark_init - # GTK leak:libEGL_mesa.so -leak:gtk_init - -# libpeas-loader-python3 -leak:libpython3.9 From 77945e35516232d621811bdd0ccea8350f0f3286 Mon Sep 17 00:00:00 2001 From: Andy Holmes Date: Tue, 29 Oct 2024 16:18:57 -0700 Subject: [PATCH 2/2] fix(sms): plug leaked GCancellable --- src/plugins/sms/valent-sms-device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/plugins/sms/valent-sms-device.c b/src/plugins/sms/valent-sms-device.c index 2a13184d97..93290e48f7 100644 --- a/src/plugins/sms/valent-sms-device.c +++ b/src/plugins/sms/valent-sms-device.c @@ -889,6 +889,7 @@ valent_sms_device_finalize (GObject *object) g_queue_clear_full (&self->attachment_requests, attachment_request_free); g_clear_pointer (&self->message_requests, g_ptr_array_unref); + g_clear_object (&self->cancellable); g_clear_object (&self->connection); g_clear_object (&self->get_timestamp_stmt);