Skip to content

Commit

Permalink
fix: fix Tabs a11y issue (ant-design#52677)
Browse files Browse the repository at this point in the history
* chore: bump rc-tabs

* chore: update snapshot
  • Loading branch information
afc163 authored Feb 7, 2025
1 parent 36c308c commit 755cde5
Show file tree
Hide file tree
Showing 10 changed files with 17 additions and 151 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -213,11 +213,9 @@ Array [
aria-controls="rc-tabs-test-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="ant-tabs-nav-more"
id="rc-tabs-test-more"
style="visibility: hidden; order: 1;"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -1181,11 +1179,9 @@ Array [
aria-controls="rc-tabs-test-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="ant-tabs-nav-more"
id="rc-tabs-test-more"
style="visibility: hidden; order: 1;"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -1337,11 +1333,9 @@ Array [
aria-controls="rc-tabs-test-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="ant-tabs-nav-more"
id="rc-tabs-test-more"
style="visibility: hidden; order: 1;"
tabindex="-1"
type="button"
>
<span
Expand Down
6 changes: 0 additions & 6 deletions components/card/__tests__/__snapshots__/demo.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,9 @@ Array [
aria-controls="null-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="ant-tabs-nav-more"
id="null-more"
style="visibility:hidden;order:1"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -1134,11 +1132,9 @@ Array [
aria-controls="null-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="ant-tabs-nav-more"
id="null-more"
style="visibility:hidden;order:1"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -1265,11 +1261,9 @@ Array [
aria-controls="null-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="ant-tabs-nav-more"
id="null-more"
style="visibility:hidden;order:1"
tabindex="-1"
type="button"
>
<span
Expand Down
4 changes: 2 additions & 2 deletions components/card/__tests__/__snapshots__/index.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ exports[`Card correct pass tabList props 1`] = `
<button
aria-label="remove"
class="ant-tabs-tab-remove"
role="tab"
tabindex="0"
type="button"
>
Expand Down Expand Up @@ -84,6 +85,7 @@ exports[`Card correct pass tabList props 1`] = `
<button
aria-label="remove"
class="ant-tabs-tab-remove"
role="tab"
tabindex="-1"
type="button"
>
Expand Down Expand Up @@ -179,11 +181,9 @@ exports[`Card correct pass tabList props 1`] = `
aria-controls="rc-tabs-test-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="ant-tabs-nav-more"
id="rc-tabs-test-more"
style="visibility: hidden; order: 1;"
tabindex="-1"
type="button"
>
<span
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29015,11 +29015,9 @@ exports[`ConfigProvider components Tabs configProvider 1`] = `
aria-controls="rc-tabs-test-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="config-tabs-nav-more"
id="rc-tabs-test-more"
style="visibility: hidden; order: 1;"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -29106,11 +29104,9 @@ exports[`ConfigProvider components Tabs configProvider componentDisabled 1`] = `
aria-controls="rc-tabs-test-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="config-tabs-nav-more"
id="rc-tabs-test-more"
style="visibility: hidden; order: 1;"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -29197,11 +29193,9 @@ exports[`ConfigProvider components Tabs configProvider componentSize large 1`] =
aria-controls="rc-tabs-test-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="config-tabs-nav-more"
id="rc-tabs-test-more"
style="visibility: hidden; order: 1;"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -29288,11 +29282,9 @@ exports[`ConfigProvider components Tabs configProvider componentSize middle 1`]
aria-controls="rc-tabs-test-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="config-tabs-nav-more"
id="rc-tabs-test-more"
style="visibility: hidden; order: 1;"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -29379,11 +29371,9 @@ exports[`ConfigProvider components Tabs configProvider componentSize small 1`] =
aria-controls="rc-tabs-test-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="config-tabs-nav-more"
id="rc-tabs-test-more"
style="visibility: hidden; order: 1;"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -29470,11 +29460,9 @@ exports[`ConfigProvider components Tabs normal 1`] = `
aria-controls="rc-tabs-test-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="ant-tabs-nav-more"
id="rc-tabs-test-more"
style="visibility: hidden; order: 1;"
tabindex="-1"
type="button"
>
<span
Expand Down Expand Up @@ -29561,11 +29549,9 @@ exports[`ConfigProvider components Tabs prefixCls 1`] = `
aria-controls="rc-tabs-test-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="prefix-Tabs-nav-more"
id="rc-tabs-test-more"
style="visibility: hidden; order: 1;"
tabindex="-1"
type="button"
>
<span
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -822,11 +822,9 @@ exports[`renders components/splitter/demo/nested-in-tabs.tsx extend context corr
aria-controls="rc-tabs-test-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="ant-tabs-nav-more"
id="rc-tabs-test-more"
style="visibility: hidden; order: 1;"
tabindex="-1"
type="button"
>
<span
Expand Down
2 changes: 0 additions & 2 deletions components/splitter/__tests__/__snapshots__/demo.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -832,11 +832,9 @@ exports[`renders components/splitter/demo/nested-in-tabs.tsx correctly 1`] = `
aria-controls="null-more-popup"
aria-expanded="false"
aria-haspopup="listbox"
aria-hidden="true"
class="ant-tabs-nav-more"
id="null-more"
style="visibility:hidden;order:1"
tabindex="-1"
type="button"
>
<span
Expand Down
Loading

0 comments on commit 755cde5

Please sign in to comment.