diff --git a/datafusion/core/src/physical_planner.rs b/datafusion/core/src/physical_planner.rs index 4d1cf1b28d8f..e065a0d791e4 100644 --- a/datafusion/core/src/physical_planner.rs +++ b/datafusion/core/src/physical_planner.rs @@ -246,6 +246,7 @@ fn create_physical_name(e: &Expr, is_first_expr: bool) -> Result { args, filter, order_by, + null_treatment: _, }) => match func_def { AggregateFunctionDefinition::BuiltIn(..) => { create_function_physical_name(func_def.name(), *distinct, args) @@ -1674,7 +1675,7 @@ pub fn create_aggregate_expr_with_name_and_maybe_filter( }; let sort_exprs = order_by.clone().unwrap_or(vec![]); - let phy_order_by = match order_by { + let order_by = match order_by { Some(e) => Some( e.iter() .map(|expr| { @@ -1693,7 +1694,7 @@ pub fn create_aggregate_expr_with_name_and_maybe_filter( == NullTreatment::IgnoreNulls; let (agg_expr, filter, order_by) = match func_def { AggregateFunctionDefinition::BuiltIn(fun) => { - let ordering_reqs = phy_order_by.clone().unwrap_or(vec![]); + let ordering_reqs = order_by.clone().unwrap_or(vec![]); let agg_expr = aggregates::create_aggregate_expr( fun, *distinct, @@ -1703,11 +1704,11 @@ pub fn create_aggregate_expr_with_name_and_maybe_filter( name, ignore_nulls, )?; - (agg_expr, filter, phy_order_by) + (agg_expr, filter, order_by) } AggregateFunctionDefinition::UDF(fun) => { let ordering_reqs: Vec = - phy_order_by.clone().unwrap_or(vec![]); + order_by.clone().unwrap_or(vec![]); let agg_expr = udaf::create_aggregate_expr( fun, @@ -1717,7 +1718,7 @@ pub fn create_aggregate_expr_with_name_and_maybe_filter( physical_input_schema, name, )?; - (agg_expr, filter, phy_order_by) + (agg_expr, filter, order_by) } AggregateFunctionDefinition::Name(_) => { return internal_err!( @@ -1725,7 +1726,7 @@ pub fn create_aggregate_expr_with_name_and_maybe_filter( ) } }; - Ok((agg_expr, filter, phy_order_by)) + Ok((agg_expr, filter, order_by)) } other => internal_err!("Invalid aggregate expression '{other:?}'"), }