From 6f56a6353bfc15b20582c6683698e72c8617a14b Mon Sep 17 00:00:00 2001
From: kamille <caoruiqiu.crq@antgroup.com>
Date: Tue, 28 Jan 2025 05:50:11 +0800
Subject: [PATCH] add todo.

---
 datafusion/functions-aggregate/src/median.rs | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/datafusion/functions-aggregate/src/median.rs b/datafusion/functions-aggregate/src/median.rs
index 11962651f386..5a5f84b0d937 100644
--- a/datafusion/functions-aggregate/src/median.rs
+++ b/datafusion/functions-aggregate/src/median.rs
@@ -387,6 +387,13 @@ impl<T: ArrowNumericType + Send> GroupsAccumulator for MedianGroupsAccumulator<T
             cur_len += group_value.len() as i32;
             offsets.push(cur_len);
         }
+        // TODO: maybe we can use `OffsetBuffer::new_unchecked` like what in `convert_to_state`,
+        // but safety should be considered more carefully here(and I am not sure if it can get
+        // performance improvement when we introduce checks to keep the safety...).
+        //
+        // Can see more details in:
+        // https://github.com/apache/datafusion/pull/13681#discussion_r1931209791
+        //
         let offsets = OffsetBuffer::new(ScalarBuffer::from(offsets));
 
         // Build inner array