Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSource::create_file_opener takes a Result argument that is never used #14797

Closed
AdamGS opened this issue Feb 20, 2025 · 0 comments · Fixed by #14798
Closed

FileSource::create_file_opener takes a Result argument that is never used #14797

AdamGS opened this issue Feb 20, 2025 · 0 comments · Fixed by #14798

Comments

@AdamGS
Copy link
Contributor

AdamGS commented Feb 20, 2025

Seems like somewhere in the shuffle of #14224, FileSource::create_file_opener got a Result argument which isn't very idiomatic IMO, especially as it doesn't seem like there's any special handling of it anywhere.

Another small point here is that the function itself returns a Result that doesn't seem to actually propagate any error (JSON and Parquet even panic), but I can imagine that some FileSource implementation in the future would like the ability to do that.
I have a Vortex PR that attempts to track the datafusion upstream and experiment with the new APIs, and while we do error there I think making those errors into panics or validating those invariants somewhere else would also make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant