You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seems like somewhere in the shuffle of #14224, FileSource::create_file_opener got a Result argument which isn't very idiomatic IMO, especially as it doesn't seem like there's any special handling of it anywhere.
Another small point here is that the function itself returns a Result that doesn't seem to actually propagate any error (JSON and Parquet even panic), but I can imagine that some FileSource implementation in the future would like the ability to do that.
I have a Vortex PR that attempts to track the datafusion upstream and experiment with the new APIs, and while we do error there I think making those errors into panics or validating those invariants somewhere else would also make sense.
The text was updated successfully, but these errors were encountered:
Seems like somewhere in the shuffle of #14224,
FileSource::create_file_opener
got aResult
argument which isn't very idiomatic IMO, especially as it doesn't seem like there's any special handling of it anywhere.Another small point here is that the function itself returns a
Result
that doesn't seem to actually propagate any error (JSON and Parquet even panic), but I can imagine that someFileSource
implementation in the future would like the ability to do that.I have a Vortex PR that attempts to track the datafusion upstream and experiment with the new APIs, and while we do error there I think making those errors into panics or validating those invariants somewhere else would also make sense.
The text was updated successfully, but these errors were encountered: