Skip to content

Commit e4fad6c

Browse files
committed
fixci
1 parent 16713c1 commit e4fad6c

File tree

4 files changed

+4
-10
lines changed

4 files changed

+4
-10
lines changed

flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/jdbc/GravitinoJdbcCatalog.java

-3
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,12 @@ public class GravitinoJdbcCatalog extends BaseCatalog {
3838

3939
private final JdbcCatalog jdbcCatalog;
4040

41-
private final CatalogFactory.Context context;
42-
4341
protected GravitinoJdbcCatalog(
4442
CatalogFactory.Context context,
4543
String defaultDatabase,
4644
PropertiesConverter propertiesConverter,
4745
PartitionConverter partitionConverter) {
4846
super(context.getName(), defaultDatabase, propertiesConverter, partitionConverter);
49-
this.context = context;
5047
JdbcCatalogFactory jdbcCatalogFactory = new JdbcCatalogFactory();
5148
this.jdbcCatalog = (JdbcCatalog) jdbcCatalogFactory.createCatalog(context);
5249
}

flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/jdbc/MysqlPropertiesConverter.java

-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323

2424
public class MysqlPropertiesConverter extends JdbcPropertiesConverter {
2525

26-
27-
2826
protected MysqlPropertiesConverter(Map<String, String> catalogOptions) {
2927
super(catalogOptions);
3028
}

flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStore.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public void storeCatalog(String catalogName, CatalogDescriptor descriptor)
5757
Map<String, String> gravitino = configuration.toMap();
5858
BaseCatalogFactory catalogFactory = getCatalogFactory(gravitino);
5959
Map<String, String> gravitinoProperties =
60-
catalogFactory.propertiesConverter().toGravitinoCatalogProperties(configuration);
60+
catalogFactory.propertiesConverter(gravitino).toGravitinoCatalogProperties(configuration);
6161
gravitinoCatalogManager.createCatalog(
6262
catalogName,
6363
catalogFactory.gravitinoCatalogType(),
@@ -80,7 +80,8 @@ public Optional<CatalogDescriptor> getCatalog(String catalogName) throws Catalog
8080
try {
8181
Catalog catalog = gravitinoCatalogManager.getGravitinoCatalogInfo(catalogName);
8282
BaseCatalogFactory catalogFactory = getCatalogFactory(catalog.provider());
83-
PropertiesConverter propertiesConverter = catalogFactory.propertiesConverter();
83+
PropertiesConverter propertiesConverter =
84+
catalogFactory.propertiesConverter(catalog.properties());
8485
Map<String, String> flinkCatalogProperties =
8586
propertiesConverter.toFlinkCatalogProperties(catalog.properties());
8687
CatalogDescriptor descriptor =

flink-connector/flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/jdbc/FlinkJdbcMysqlCatalogIT.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import org.apache.gravitino.Catalog;
2828
import org.apache.gravitino.flink.connector.integration.test.FlinkCommonIT;
2929
import org.apache.gravitino.flink.connector.jdbc.JdbcPropertiesConstants;
30-
import org.apache.gravitino.flink.connector.jdbc.MysqlPropertiesConverter;
3130
import org.apache.gravitino.integration.test.container.ContainerSuite;
3231
import org.junit.jupiter.api.AfterAll;
3332
import org.junit.jupiter.api.Assertions;
@@ -166,7 +165,6 @@ public void testCreateGravitinoJdbcCatalogUsingSQL() {
166165
mysqlDefaultDatabase,
167166
properties.get(JdbcPropertiesConstants.GRAVITINO_JDBC_DEFAULT_DATABASE));
168167
Assertions.assertEquals(
169-
"com.mysql.jdbc.Driver",
170-
properties.get(JdbcPropertiesConstants.GRAVITINO_JDBC_DRIVER));
168+
"com.mysql.jdbc.Driver", properties.get(JdbcPropertiesConstants.GRAVITINO_JDBC_DRIVER));
171169
}
172170
}

0 commit comments

Comments
 (0)