Skip to content

Commit f6b631a

Browse files
committed
Typo
1 parent 19143ab commit f6b631a

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

clients/client-python/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@
2828

2929
+ Test Principle: Every Python ITs class base on the `IntegrationTestEnv`, `IntegrationTestEnv` will automatically start and stop Gravitino server to support ITs, But when you run multiple ITs class at same time, The first test class that finishes running will shut down the Gravitino server, which will cause other test classes to fail if they can't connect to the Gravitino server.
3030
+ Run test in the IDE: Through `IntegrationTestEnv` class automatically start and stop Gravitino server to support ITs.
31-
+ Run test in the GitHub Action or Gradle command `:client:client-python:test`: Gradle automatically start and stop Gravitino server, and set `EXTERNAL_START_GRAVITINO` environment variable.
31+
+ Run test in the GitHub Action or Gradle command `:client:client-python:test`: Gradle automatically start and stop Gravitino server, and set `START_EXTERNAL_GRAVITINO` environment variable.

clients/client-python/gravitino/client/gravitino_metalake.py

-8
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,7 @@ class GravitinoMetalake(MetalakeDTO):
4747

4848
API_METALAKES_CATALOGS_PATH = "api/metalakes/{}/catalogs/{}"
4949

50-
# def __init__(self, name: str = None, comment: str = None, properties: Dict[str, str] = None, audit: AuditDTO = None,
51-
# rest_client: HTTPClient = None):
52-
# super().__init__(_name=name, _comment=comment, _properties=properties, _audit=audit)
53-
# self.rest_client = rest_client
54-
55-
# @classmethod
5650
def __init__(self, metalake: MetalakeDTO = None, client: HTTPClient = None):
57-
# return cls(name=metalake.name(), comment=metalake.comment(), properties=metalake.properties(),
58-
# audit=metalake.audit_info(), rest_client=client)
5951
super().__init__(_name=metalake.name(), _comment=metalake.comment(), _properties=metalake.properties(),
6052
_audit=metalake.audit_info())
6153
self.rest_client = client

0 commit comments

Comments
 (0)