Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9149]Assign offset in offsetTable even if the subscription key not exist. #9150

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

dingshuangxi888
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9149

Brief Description

When resetting offsets, it is equally required to persist the offset information for subscription relationships that have never been online, to support scenarios where offset synchronization is needed for backup clusters.

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.02%. Comparing base (8086fc5) to head (5f3464f).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #9150   +/-   ##
==========================================
  Coverage      48.01%   48.02%           
- Complexity     12082    12085    +3     
==========================================
  Files           1321     1321           
  Lines          93049    93040    -9     
  Branches       11927    11924    -3     
==========================================
  Hits           44681    44681           
- Misses         42831    42834    +3     
+ Partials        5537     5525   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 0176ef4 into apache:develop Feb 6, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Assign offset in offsetTable even if the subscriptio not exist.
4 participants