Merge remote-tracking branch 'origin/main' into aperture

Signed-off-by: Christian Stewart <christian@aperture.us>

Author: paralin

.github/workflows/ci.yml

@@ -215,4 +215,3 @@ jobs:
 
       - name: make test-old-ts
         run: make test-old-ts
-

CHANGELOG.md

@@ -1,5 +1,80 @@
 # Changelog
 
+## Unreleased
+
+* Optimize the generated code for private methods
+
+    Previously when lowering private methods for old browsers, esbuild would generate one `WeakSet` for each private method. This mirrors similar logic for generating one `WeakSet` for each private field. Using a separate `WeakMap` for private fields is necessary as their assignment can be observable:
+
+    ```js
+    let it
+    class Bar {
+      constructor() {
+        it = this
+      }
+    }
+    class Foo extends Bar {
+      #x = 1
+      #y = null.foo
+      static check() {
+        console.log(#x in it, #y in it)
+      }
+    }
+    try { new Foo } catch {}
+    Foo.check()
+    ```
+
+    This prints `true false` because this partially-initialized instance has `#x` but not `#y`. In other words, it's not true that all class instances will always have all of their private fields. However, the assignment of private methods to a class instance is not observable. In other words, it's true that all class instances will always have all of their private methods. This means esbuild can lower private methods into code where all methods share a single `WeakSet`, which is smaller, faster, and uses less memory. Other JavaScript processing tools such as the TypeScript compiler already make this optimization. Here's what this change looks like:
+
+    ```js
+    // Original code
+    class Foo {
+      #x() { return this.#x() }
+      #y() { return this.#y() }
+      #z() { return this.#z() }
+    }
+
+    // Old output (--supported:class-private-method=false)
+    var _x, x_fn, _y, y_fn, _z, z_fn;
+    class Foo {
+      constructor() {
+        __privateAdd(this, _x);
+        __privateAdd(this, _y);
+        __privateAdd(this, _z);
+      }
+    }
+    _x = new WeakSet();
+    x_fn = function() {
+      return __privateMethod(this, _x, x_fn).call(this);
+    };
+    _y = new WeakSet();
+    y_fn = function() {
+      return __privateMethod(this, _y, y_fn).call(this);
+    };
+    _z = new WeakSet();
+    z_fn = function() {
+      return __privateMethod(this, _z, z_fn).call(this);
+    };
+
+    // New output (--supported:class-private-method=false)
+    var _Foo_instances, x_fn, y_fn, z_fn;
+    class Foo {
+      constructor() {
+        __privateAdd(this, _Foo_instances);
+      }
+    }
+    _Foo_instances = new WeakSet();
+    x_fn = function() {
+      return __privateMethod(this, _Foo_instances, x_fn).call(this);
+    };
+    y_fn = function() {
+      return __privateMethod(this, _Foo_instances, y_fn).call(this);
+    };
+    z_fn = function() {
+      return __privateMethod(this, _Foo_instances, z_fn).call(this);
+    };
+    ```
+
 ## 0.20.2
 
 * Support TypeScript experimental decorators on `abstract` class fields ([#3684](https://github.com/evanw/esbuild/issues/3684))

cmd/esbuild/main.go

@@ -127,6 +127,7 @@ var helpText = func(colors logger.Colors) string {
   --supported:F=...         Consider syntax F to be supported (true | false)
   --tree-shaking=...        Force tree shaking on or off (false | true)
   --tsconfig=...            Use this tsconfig.json file instead of other ones
+  --tsconfig-raw=...        Override all tsconfig.json files with this string
   --version                 Print the current version (` + esbuildVersion + `) and exit
 
 ` + colors.Bold + `Examples:` + colors.Reset + `
@@ -331,12 +332,16 @@ func main() {
 					for {
 						_, err := os.Stdin.Read(buffer)
 						if err != nil {
-							// Mention why watch mode was stopped to reduce confusion, and
-							// call out "--watch=forever" to get the alternative behavior
-							if isWatch {
-								if options := logger.OutputOptionsForArgs(osArgs); options.LogLevel <= logger.LevelInfo {
+							if options := logger.OutputOptionsForArgs(osArgs); options.LogLevel <= logger.LevelInfo {
+								if isWatch {
+									// Mention why watch mode was stopped to reduce confusion, and
+									// call out "--watch=forever" to get the alternative behavior
 									logger.PrintTextWithColor(os.Stderr, options.Color, func(colors logger.Colors) string {
-										return fmt.Sprintf("%s[watch] stopped because stdin was closed (use \"--watch=forever\" to keep watching even after stdin is closed)%s\n", colors.Dim, colors.Reset)
+										return fmt.Sprintf("%s[watch] stopped automatically because stdin was closed (use \"--watch=forever\" to keep watching even after stdin is closed)%s\n", colors.Dim, colors.Reset)
+									})
+								} else if isServeOrWatch {
+									logger.PrintTextWithColor(os.Stderr, options.Color, func(colors logger.Colors) string {
+										return fmt.Sprintf("%s[serve] stopped automatically because stdin was closed (keep stdin open to continue serving)%s\n", colors.Dim, colors.Reset)
 									})
 								}
 							}

compat-table/package-lock.json

@@ -1,12 +1,12 @@
 {
   "githubDependencies": {
     "kangax/compat-table": "1a1ccdc02b8b2158ab39a6146d8a7308f43c830b",
-    "williamkapke/node-compat-table": "cd9bf26864ac83dea133bf50059c5eb81e4518df"
+    "williamkapke/node-compat-table": "3b8791b9f31a4f7c14f4c5f496fff8a27c566ae6"
   },
   "dependencies": {
-    "@mdn/browser-compat-data": "5.5.4",
+    "@mdn/browser-compat-data": "5.5.23",
     "@types/caniuse-lite": "1.0.1",
     "@types/node": "20.3.2",
-    "caniuse-lite": "1.0.30001574"
+    "caniuse-lite": "1.0.30001612"
   }
 }

compat-table/package.json

@@ -66,12 +66,9 @@ const cssFeatures: Partial<Record<CSSFeature, string | string[]>> = {
   Modern_RGB_HSL: [
     'css.types.color.hsl.alpha_parameter',
     'css.types.color.hsl.space_separated_parameters',
-    'css.types.color.hsla.space_separated_parameters',
     'css.types.color.rgb.alpha_parameter',
     'css.types.color.rgb.float_values',
     'css.types.color.rgb.space_separated_parameters',
-    'css.types.color.rgba.float_values',
-    'css.types.color.rgba.space_separated_parameters',
   ],
   Nesting: 'css.selectors.nesting',
   RebeccaPurple: 'css.types.color.named-color.rebeccapurple',