Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to compute piece commitment - blockstore: block not found #330

Closed
en0ma opened this issue Jul 19, 2022 · 1 comment
Closed

failed to compute piece commitment - blockstore: block not found #330

en0ma opened this issue Jul 19, 2022 · 1 comment
Labels
Bug Something that should be fixed.

Comments

@en0ma
Copy link
Contributor

en0ma commented Jul 19, 2022

Describe the bug
Given that during file uploads, identity CIDs are skipped, and so they are not looked up from the blockstore #215 - (has some relationship to this discussion here multiformats/cid#21)

When Estuary tries to compute commp at https://github.com/application-research/estuary/blob/master/replication.go#L2627, it is not aware they are not in the blockstore, and so it fails with errors like;

2022-07-12T17:15:12.789Z        ERROR   estuary estuary/replication.go:1389     failed to compute piece commitment for content 1: failed to generate piece commitment: error traversing node at "Links/7/Hash": could not load link "bafkqaaa": blockstore: block not found    {"app_version": "v0.1.3-8-g2e22f4d-dirty"}

bafkqaaa is an identity cid and will not be in the blockstore

To Reproduce
Steps to reproduce the behavior:

  1. Run Estuary locally
  2. Upload a car file with identity cid
  3. Get it to generate commp
  4. It will fail to get the block for the identity cid

Expected behavior
Commp should be calculated correctly on the Estuary side

Actual behavior
Commp fails to be calculated on the Estuary side. it fails with error

2022-07-12T17:15:12.789Z        ERROR   estuary estuary/replication.go:1389     failed to compute piece commitment for content 1: failed to generate piece commitment: error traversing node at "Links/7/Hash": could not load link "bafkqaaa": blockstore: block not found    {"app_version": "v0.1.3-8-g2e22f4d-dirty"}
@en0ma en0ma added the Bug Something that should be fixed. label Jul 19, 2022
@en0ma
Copy link
Contributor Author

en0ma commented Oct 26, 2022

addressed in #470

@en0ma en0ma closed this as completed Oct 26, 2022
Repository owner moved this from Backlog to Done in Estuary Engineering Task Board Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something that should be fixed.
Projects
Development

No branches or pull requests

1 participant