test(protos): update test to use helper macro.

Author: aptenodytes-forsteri

language/proto/BUILD.bazel

@@ -1,6 +1,6 @@
 load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
 load("//language/proto/gen:def.bzl", "known_imports")
-
+load("//internal/generationtest:generation_test.bzl", "gazelle_generation_test")
 # gazelle:exclude testdata*
 
 known_imports(
@@ -88,7 +88,6 @@ go_test(
         "//testtools",
         "//walk",
         "@com_github_bazelbuild_buildtools//build:go_default_library",
-        "@io_bazel_rules_go//go/tools/bazel:go_default_library",
     ],
 )
 
@@ -126,3 +125,16 @@ alias(
     actual = ":proto",
     visibility = ["//visibility:public"],
 )
+
+filegroup(
+    name = "generation_test_data",
+    srcs = glob([
+        "testdata_full_gen_test/**",
+    ]),
+)
+
+gazelle_generation_test(
+    name = "generation_test",
+    gazelle_binary = "//:gazelle_local",
+    test_data = ":generation_test_data",
+)

language/proto/generate_test.go

@@ -31,7 +31,6 @@ import (
 	"github.com/bazelbuild/bazel-gazelle/rule"
 	"github.com/bazelbuild/bazel-gazelle/testtools"
 	"github.com/bazelbuild/bazel-gazelle/walk"
-	"github.com/bazelbuild/rules_go/go/tools/bazel"
 
 	bzl "github.com/bazelbuild/buildtools/build"
 )
@@ -361,40 +360,3 @@ func testConfig(t *testing.T, repoRoot string) (*config.Config, language.Languag
 	cexts = append(cexts, lang)
 	return c, lang, cexts
 }
-
-// TestFullGeneration runs the gazelle binary on a few example
-// workspaces and confirms that the generated BUILD files match expectation.
-func TestFullGeneration(t *testing.T) {
-	tests := map[string][]bazel.RunfileEntry{}
-	runfiles, err := bazel.ListRunfiles()
-	if err != nil {
-		t.Fatalf("bazel.ListRunfiles() error: %v", err)
-	}
-	testDataDirectory := "testdata_full_gen_test"
-	testDataPath := filepath.Join("language", "proto", testDataDirectory, "")
-	for _, f := range runfiles {
-		if strings.HasPrefix(f.ShortPath, testDataPath) {
-			relativePath := strings.TrimPrefix(f.ShortPath, testDataPath)
-			parts := strings.SplitN(relativePath, "/", 3)
-			if len(parts) < 3 {
-				// This file is not a part of a testcase since it must be in a dir that
-				// is the test case and then have a path inside of that.
-				continue
-			}
-
-			tests[parts[1]] = append(tests[parts[1]], f)
-		}
-	}
-	if len(tests) == 0 {
-		t.Fatal("no tests found")
-	}
-
-	testArgs := testtools.NewTestGazelleGenerationArgs()
-	for testName, files := range tests {
-		testArgs.Name = testName
-		testArgs.TestDataPath = testDataPath
-		testArgs.GazelleBinaryDir = ""
-		testArgs.GazelleBinaryName = "gazelle_local"
-		testtools.TestGazelleGenerationOnPath(t, testArgs, files)
-	}
-}