Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2] Clang-Tidy: Warning level discussion #116

Open
ChenMiaoi opened this issue Dec 14, 2024 · 2 comments
Open

[P2] Clang-Tidy: Warning level discussion #116

ChenMiaoi opened this issue Dec 14, 2024 · 2 comments

Comments

@ChenMiaoi
Copy link
Collaborator

ChenMiaoi commented Dec 14, 2024

Which kiwi functionalities are relevant/related to the feature request?

other

Description

This is because all warnings are treated as Error warnings in the original clang-tidy check WarningsAsErrors, resulting in too many warnings when doing jobs(similar to vscode).

image

Therefore, it is necessary to discuss which warnings should be treated as errors.

Proposed solution

No response

Alternatives considered

No response

@marsevilspirit
Copy link
Collaborator

我觉得可以先将*去掉 在看看那些warning是不能被接受的 再单独添加上

@luky116 luky116 changed the title Clang-Tidy: Warning level discussion [P2] Clang-Tidy: Warning level discussion Dec 21, 2024
@luky116
Copy link
Collaborator

luky116 commented Dec 21, 2024

先不处理,等会影响开发了再关注

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants