Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove variable content feature #113

Open
woodhull opened this issue Jan 22, 2025 · 5 comments
Open

Remove variable content feature #113

woodhull opened this issue Jan 22, 2025 · 5 comments

Comments

@woodhull
Copy link
Contributor

We'd like to remove the current variable content feature. Is there a straightforward way to hide it without forking the library?

In the future, we're likely to implement a different strategy for inserting variables, but currently it doesn't seem like you can turn off the "Show Conditionally" feature on blocks easily.

If this does not exist, is this something you'd be interested in?

Nathan

@arikchakma
Copy link
Owner

Sorry? Which variable content are you taking about?

@woodhull
Copy link
Contributor Author

This feature:

Image

I'm not sure how to turn it off.

@arikchakma
Copy link
Owner

We can do it in a config, but currently there is no way to turn it off.

@woodhull
Copy link
Contributor Author

I've removed this feature in my fork, if there is a future extensions API that will support this sort of modification, I can write a PR against that.

Our motivation here so you're across the context of what we're up to:

We have an existing personalization engine that runs server-side using liquid templates. We're likely to extend the editor to support tiptap marks for liquid tags and add some way to insert liquid variables from the bubble menu.

We're also not using the render functionality of maily.to, but instead translating the tiptap document into mjml for rendering. I may extract the ruby code that does the tiptap nodes => mjml transformation into a ruby gem in case anyone else needs to do something similar.

Not looking for y'all to support our divergent use-case for a nice editor UI but if we can re-use code in core that seems like a win for everyone.

@arikchakma
Copy link
Owner

I will add the modification in the extension API, simplifying the process. Please let me know what you think. You can schedule a meeting to talk about it more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants