Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tlmcmddb.json の互換性が一部失われてしまっている #98

Closed
sksat opened this issue Dec 5, 2024 · 5 comments · Fixed by #99, #102 or #103
Closed

tlmcmddb.json の互換性が一部失われてしまっている #98

sksat opened this issue Dec 5, 2024 · 5 comments · Fixed by #99, #102 or #103
Assignees
@sksat
Labels
bug Something isn't working

Comments

@sksat
Copy link
Member

sksat commented Dec 5, 2024

@sksat sksat added the bug Something isn't working label Dec 5, 2024
@sksat sksat self-assigned this Dec 5, 2024
@sksat sksat mentioned this issue Dec 5, 2024
Merged
@sksat
Copy link
Member Author

sksat commented Dec 5, 2024

serde(alias) は Deserializer の話なので、Serializer は単に構造体のフィールド名で出力してしまい、古い実装から読めない tlmcmddb.json が発生してしまっている

https://serde.rs/field-attrs.html#alias

Deserialize this field from the given name or from its Rust name. May be repeated to specify multiple possible names for the same field.

@sksat
Copy link
Member Author

sksat commented Dec 5, 2024

tlmcmddb の互換性は結構重要なので、この問題だけでなく、このようなことが起こらないようにテストケースを組みたい

@sksat
Copy link
Member Author

sksat commented Dec 5, 2024

tlmcmddb-csv のテストはちょうどこのフィールドの下のコンテキストだったからすり抜けたのか

@sksat sksat mentioned this issue Dec 5, 2024
Merged
@sksat sksat closed this as completed in #99 Dec 5, 2024
@sksat sksat reopened this Dec 5, 2024
@sksat sksat mentioned this issue Dec 5, 2024
Merged
@sksat
Copy link
Member Author

sksat commented Dec 5, 2024 

          あと、display info も増えてる（#41）ので、これだけでは問題は解決しない

Originally posted by @sksat in #101 (comment)

@sksat sksat mentioned this issue Dec 5, 2024
Merged
@sksat
Copy link
Member Author

sksat commented Dec 5, 2024

v2.6.0 を yank した

@sksat sksat closed this as completed in #102 Dec 5, 2024
@sksat sksat reopened this Dec 5, 2024
@sksat sksat mentioned this issue Dec 5, 2024
Merged
@sksat sksat closed this as completed in #103 Dec 5, 2024
@sksat sksat mentioned this issue Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sksat sksat

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@sksat