Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

htmlwhat package not providing correct feedback after code changes #1

Open
ChoudhariNikita opened this issue Jul 6, 2024 · 1 comment
Open

htmlwhat package not providing correct feedback after code changes #1

ChoudhariNikita opened this issue Jul 6, 2024 · 1 comment

Comments

@ChoudhariNikita
Copy link

Issue Description

The htmlwhat package, used for validating HTML code submissions, is not functioning correctly when I modify the HTML code being tested.

Steps to Reproduce

  1. Code Example:

    from htmlwhat.test_exercise import test_exercise

userhtml = """
<!DOCTYPE html>
<html>
    <head>
        <title>Title</title>
    </head>
    <body class="hello">
        <h1>My First Heading</h1>
    </body>
</html>
"""

solutionhtml = """
<!DOCTYPE html>
<html>
    <head>
        <title>First Webpage</title>
    </head>
    <body class="hello">
        <h2>My First Heading</h2>
    </body>
</html>
"""

test = "Ex().check_body().has_equal_attr()"

print(test_exercise(
    test,
    userhtml,
    solutionhtml,
))

Expected Behavior

The test_exercise function should provide accurate feedback on the differences between userhtml and solutionhtml, confirming correctness or pointing out discrepancies based on the test provided (Ex().check_body().has_equal_attr()).

Actual Behavior

Currently, the output from test_exercise does not accurately reflect the correctness of the HTML code when modifications are made to either userhtml or solutionhtml. Instead, it fails to detect changes or provides incorrect feedback.

Additional Information

  • htmlwhat is typically used in educational contexts to assess HTML assignments.
  • This issue affects the reliability and functionality of htmlwhat, which is crucial for providing accurate feedback on HTML correctness.

This issue impacts the reliability and functionality of the feedback mechanism crucial for assessing correctness in HTML submissions.
@shraysalvi
Copy link
Contributor

shraysalvi commented Dec 17, 2024 •
edited
Loading

@ChoudhariNikita I am not getting your point as this is working fine and fif you are looking for the syntax error then at this stage it is not possible as we are using beautifulsoup to parse code which automatically correct html syntactically.

Provide more details on your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shraysalvi @ChoudhariNikita