Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command demo: get_key_info #403

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Command demo: get_key_info #403

merged 2 commits into from
Sep 12, 2024

Conversation

Maceeran
Copy link
Collaborator

@Maceeran Maceeran commented Sep 12, 2024 •
edited
Loading

Description

Added a demo page showcasing the usage of get_key_info command.

Checklist

Changes to the drivers

  • (PR Author) The affected drivers were manually tested

Changes to CLI

  • (PR Author) The change was manually tested with the CLI
  • (PR Author) The affected CLI features are working with the standalone binary (at least one platform)
  • (Checked by maintainer) The CLI test procedure was run by the project's maintainer

Changes to web library

  • (PR Author) The change was manually tested with the web library included within a classic HTML application (flat libhalo.js)
  • (PR Author) The change was manually tested with the web library included within an app based on frontend framework (React.js or similar based on webpack)
  • (Checked by maintainer) The web test suite was run by the project's maintainer

Changes to nfc-manager driver

  • (PR Author) The change was manually tested in React Native app
  • (Checked by maintainer) The test suite was run through the test React Native project

@Maceeran Maceeran requested a review from icedevml September 12, 2024 23:09
@Maceeran Maceeran linked an issue Sep 12, 2024 that may be closed by this pull request
halo-demos: Implement a demo for get_key_info command #396
Closed
@icedevml icedevml self-requested a review September 12, 2024 23:19
@icedevml
Copy link
Collaborator

lgtm, thanks 🎉

@icedevml icedevml merged commit 007a801 into master Sep 12, 2024
6 checks passed
@icedevml icedevml deleted the feature/get-key-info-demo branch September 12, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icedevml icedevml icedevml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

halo-demos: Implement a demo for get_key_info command
2 participants
@Maceeran @icedevml