Gateway requestor: support for sending digest #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gateway_requestor.html
icedevml
approved these changes
Sep 13, 2024
Comment on lines
+106
to
+119
| async function generateRandomDigest() { | ||
| const rnd = new Uint8Array(6); | ||
| crypto.getRandomValues(rnd); | ||
|
|
||
| const msgBuffer = new TextEncoder().encode(rnd); | ||
| const hashBuffer = await crypto.subtle.digest('SHA-256', msgBuffer); | ||
| const hashArray = Array.from(new Uint8Array(hashBuffer)); | ||
|
|
||
| const hashHex = hashArray.map(b => b.toString(16).padStart(2, '0')).join(''); | ||
|
|
||
| document.getElementById('digest').value = hashHex; | ||
| document.getElementById('signBtn').disabled = true; | ||
| document.getElementById('signBtn').style.display = 'none'; | ||
| } |
There was a problem hiding this comment.
Just a note, any random 32 byte hex string would be a valid SHA-256 hash. Of course then we wouldn't know what was the original input that was hashed, but it's also not necessary for this demo.
Nevertheless, I like the approach of generating a random message and then hashing it on the client side, it's a bit more descriptive. LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for selecting whether to send "message" or "digest" in gateway_requestor.html
Description
Checklist
Changes to the drivers
Changes to CLI
Changes to web library
libhalo.js)Changes to nfc-manager driver