Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate demos into mobile-only, desktop-only and mobile and desktop compatible #407

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

Maceeran
Copy link
Collaborator

Description

  • Separated example link list into mobile-only, desktop-only and mobile and desktop compatible lists
  • Added mobile-only/desktop-only information into individual example pages where applicable
  • Standardized demo description styling(set class to "text-muted")

Checklist

Changes to the drivers

  • (PR Author) The affected drivers were manually tested

Changes to CLI

  • (PR Author) The change was manually tested with the CLI
  • (PR Author) The affected CLI features are working with the standalone binary (at least one platform)
  • (Checked by maintainer) The CLI test procedure was run by the project's maintainer

Changes to web library

  • (PR Author) The change was manually tested with the web library included within a classic HTML application (flat libhalo.js)
  • (PR Author) The change was manually tested with the web library included within an app based on frontend framework (React.js or similar based on webpack)
  • (Checked by maintainer) The web test suite was run by the project's maintainer

Changes to nfc-manager driver

  • (PR Author) The change was manually tested in React Native app
  • (Checked by maintainer) The test suite was run through the test React Native project

…se meant to be run on desktop and another set of those to be run on mobile.
* Added another list(Mobile and desktop compatible) into index.html
@icedevml icedevml merged commit 549c075 into master Sep 15, 2024
6 checks passed
@icedevml icedevml deleted the feature/separate-demos-mobile-pc branch September 15, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

halo-demos: Add clear info that certain demos are for running on smartphones, while others on PCs
2 participants