Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in depth backward #4

Closed
yihua7 opened this issue Oct 4, 2023 · 3 comments
Closed

Bug in depth backward #4

yihua7 opened this issue Oct 4, 2023 · 3 comments

Comments

@yihua7
Copy link

yihua7 commented Oct 4, 2023 •
edited
Loading

There exists a bug of lacking a parentheses here, referring to the issue.
The backward of depth estimation may encounter CUDA error based on the current codes.
@ashawkey
Copy link
Owner

ashawkey commented Oct 4, 2023

@yihua7 Thanks for spotting this! I have fixed it in d210917.

@yihua7
Copy link
Author

yihua7 commented Oct 4, 2023

Sure :)
By the way, I really appreciate your excellent projects. Based on torch-ngp I developed my SIGGRAPH paper NeRF-Texture. I have acknowledged it on the website.
Looking forward to your future works and learning more from you :)

@yihua7 yihua7 closed this as completed Oct 4, 2023
@ashawkey
Copy link
Owner

ashawkey commented Oct 4, 2023

Nice work! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashawkey @yihua7