Skip to content

Commit 0c487f3

Browse files
committed
Rename snowballing to snowball
This aligns better with the other arguments.
1 parent 08e15de commit 0c487f3

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

asreviewcontrib/datatools/entrypoint.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
from asreviewcontrib.datatools.convert import convert
1010
from asreviewcontrib.datatools.describe import _parse_arguments_describe
1111
from asreviewcontrib.datatools.describe import describe
12-
from asreviewcontrib.datatools.snowballing import _parse_arguments_snowballing
13-
from asreviewcontrib.datatools.snowballing import snowballing
12+
from asreviewcontrib.datatools.snowball import _parse_arguments_snowball
13+
from asreviewcontrib.datatools.snowball import snowball
1414
from asreviewcontrib.datatools.stack import _parse_arguments_vstack
1515
from asreviewcontrib.datatools.stack import vstack
1616

@@ -98,9 +98,9 @@ def execute(self, argv):
9898
resolve=args_compose.conflict_resolve,
9999
)
100100
if argv[0] == "snowballing":
101-
args_snowballing_parser = _parse_arguments_snowballing()
101+
args_snowballing_parser = _parse_arguments_snowball()
102102
args_snowballing = vars(args_snowballing_parser.parse_args(argv[1:]))
103-
snowballing(**args_snowballing)
103+
snowball(**args_snowballing)
104104
if argv[0] == "vstack":
105105
args_vstack_parser = _parse_arguments_vstack()
106106
args_vstack = args_vstack_parser.parse_args(argv[1:])

asreviewcontrib/datatools/snowballing.py asreviewcontrib/datatools/snowball.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ def openalex_from_doi(dois: list[str]) -> dict[str, str]:
168168
return id_mapping
169169

170170

171-
def snowballing(
171+
def snowball(
172172
input_path: Path,
173173
output_path: Path,
174174
forward: bool,
@@ -266,7 +266,7 @@ def snowballing(
266266
print("Saved dataset")
267267

268268

269-
def _parse_arguments_snowballing():
269+
def _parse_arguments_snowball():
270270
parser = argparse.ArgumentParser(prog="asreview data snowballing")
271271
parser.add_argument(
272272
"input_path", type=str, help="The file path of the input dataset."

tests/test_snowballing.py tests/test_snowball.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
import pandas as pd
44

5-
from asreviewcontrib.datatools.snowballing import backward_snowballing
6-
from asreviewcontrib.datatools.snowballing import forward_snowballing
7-
from asreviewcontrib.datatools.snowballing import openalex_from_doi
8-
from asreviewcontrib.datatools.snowballing import snowballing
5+
from asreviewcontrib.datatools.snowball import backward_snowballing
6+
from asreviewcontrib.datatools.snowball import forward_snowballing
7+
from asreviewcontrib.datatools.snowball import openalex_from_doi
8+
from asreviewcontrib.datatools.snowball import snowball
99

1010
INPUT_DIR = Path(__file__).parent / "demo_data"
1111

@@ -58,7 +58,7 @@ def test_forward_snowballing():
5858

5959
def test_openalex_id_forward(tmpdir):
6060
out_fp = Path(tmpdir, "forward_all.csv")
61-
snowballing(
61+
snowball(
6262
input_path=INPUT_DIR / "snowballing_openalex.csv",
6363
output_path=out_fp,
6464
forward=True,
@@ -69,7 +69,7 @@ def test_openalex_id_forward(tmpdir):
6969
assert len(df) >= 23
7070

7171
all_out_fp = Path(tmpdir, "forward_all.csv")
72-
snowballing(
72+
snowball(
7373
input_path=INPUT_DIR / "snowballing_openalex.csv",
7474
output_path=all_out_fp,
7575
forward=True,
@@ -82,7 +82,7 @@ def test_openalex_id_forward(tmpdir):
8282

8383
def test_openalex_id_backward(tmpdir):
8484
out_fp = Path(tmpdir, "forward_all.csv")
85-
snowballing(
85+
snowball(
8686
input_path=INPUT_DIR / "snowballing_openalex.csv",
8787
output_path=out_fp,
8888
forward=False,
@@ -93,7 +93,7 @@ def test_openalex_id_backward(tmpdir):
9393
assert len(df) == 31
9494

9595
all_out_fp = Path(tmpdir, "backward_all.csv")
96-
snowballing(
96+
snowball(
9797
input_path=INPUT_DIR / "snowballing_openalex.csv",
9898
output_path=all_out_fp,
9999
forward=False,
@@ -106,7 +106,7 @@ def test_openalex_id_backward(tmpdir):
106106

107107
def test_snowballing_from_doi(tmpdir):
108108
out_fp = Path(tmpdir, "doi_all.csv")
109-
snowballing(
109+
snowball(
110110
input_path=INPUT_DIR / "snowballing_doi.csv",
111111
output_path=out_fp,
112112
forward=False,

0 commit comments

Comments
 (0)