Skip to content

Commit

Permalink
only allow 1 tx to be submitted to the gRPC collector
Browse files Browse the repository at this point in the history
  • Loading branch information
bharath-123 committed Mar 31, 2024
1 parent 3a574b0 commit e7d3da8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 18 deletions.
27 changes: 10 additions & 17 deletions crates/astria-composer/tests/blackbox/composer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ use astria_core::{
generated::{
composer::v1alpha1::{
grpc_collector_service_client::GrpcCollectorServiceClient,
RollupTransaction,
SubmitRollupTransactionsRequest,
SubmitRollupTransactionRequest,
},
sequencer::v1::NonceResponse,
},
Expand Down Expand Up @@ -85,11 +84,9 @@ async fn tx_from_one_rollup_is_received_by_sequencer_from_grpc_collector() {
.await
.unwrap();
composer_client
.submit_rollup_transactions(SubmitRollupTransactionsRequest {
rollup_transactions: vec![RollupTransaction {
rollup_id: rollup_id.as_ref().to_vec(),
data: tx.rlp().to_vec(),
}],
.submit_rollup_transaction(SubmitRollupTransactionRequest {
rollup_id: rollup_id.as_ref().to_vec(),
data: tx.rlp().to_vec(),
})
.await
.expect("error submitting sequence actions to generic collector");
Expand Down Expand Up @@ -255,11 +252,9 @@ async fn invalid_nonce_failure_causes_tx_resubmission_under_different_nonce_grpc
.await
.unwrap();
composer_client
.submit_rollup_transactions(SubmitRollupTransactionsRequest {
rollup_transactions: vec![RollupTransaction {
rollup_id: rollup_id.as_ref().to_vec(),
data: tx.rlp().to_vec(),
}],
.submit_rollup_transaction(SubmitRollupTransactionRequest {
rollup_id: rollup_id.as_ref().to_vec(),
data: tx.rlp().to_vec(),
})
.await
.expect("error submitting sequence actions to generic collector");
Expand Down Expand Up @@ -339,11 +334,9 @@ async fn single_rollup_tx_payload_integrity_grpc_collector() {
.await
.unwrap();
composer_client
.submit_rollup_transactions(SubmitRollupTransactionsRequest {
rollup_transactions: vec![RollupTransaction {
rollup_id: rollup_id.as_ref().to_vec(),
data: tx.rlp().to_vec(),
}],
.submit_rollup_transaction(SubmitRollupTransactionRequest {
rollup_id: rollup_id.as_ref().to_vec(),
data: tx.rlp().to_vec(),
})
.await
.expect("error submitting sequence actions to generic collector");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ message SubmitRollupTransactionRequest {
// It's currently an empty response which can be evolved in the future to include more information
message SubmitRollupTransactionResponse {}


// GrpcCollectorService is a service that defines the gRPC collector of the Composer
service GrpcCollectorService {
// SubmitRollupTransaction submits a rollup transactions to the Composer.
Expand Down

0 comments on commit e7d3da8

Please sign in to comment.