From f89e1eebd5a2060788e087653352ee9ce22091a0 Mon Sep 17 00:00:00 2001
From: elizabeth <elizabethjbinks@gmail.com>
Date: Mon, 24 Feb 2025 13:47:26 -0500
Subject: [PATCH] address comments

---
 crates/astria-core/src/connect/types.rs          | 2 +-
 crates/astria-core/src/primitive/v1/i128.rs      | 5 +++++
 crates/astria-sequencer/src/app/tests_app/mod.rs | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/crates/astria-core/src/connect/types.rs b/crates/astria-core/src/connect/types.rs
index 894b66268..7544524ff 100644
--- a/crates/astria-core/src/connect/types.rs
+++ b/crates/astria-core/src/connect/types.rs
@@ -452,7 +452,7 @@ pub mod v2 {
         #[test]
         fn can_parse_negative_price() {
             let price = "-1".parse::<Price>().unwrap();
-            assert_eq!(price.get(), -1);
+            assert_eq!(price, Price::new(-1));
         }
     }
 }
diff --git a/crates/astria-core/src/primitive/v1/i128.rs b/crates/astria-core/src/primitive/v1/i128.rs
index dbc83d99a..26c8b7e55 100644
--- a/crates/astria-core/src/primitive/v1/i128.rs
+++ b/crates/astria-core/src/primitive/v1/i128.rs
@@ -40,6 +40,7 @@ mod tests {
         let actual: i128 = pb.into();
         assert_eq!(expected, actual);
     }
+
     #[test]
     fn i128_roundtrips_work() {
         i128_roundtrip_check(0i128);
@@ -49,5 +50,9 @@ mod tests {
         i128_roundtrip_check(1i128 << 127);
         i128_roundtrip_check((1i128 << 127) + (1i128 << 63));
         i128_roundtrip_check(i128::MAX);
+        i128_roundtrip_check(i128::MIN);
+        i128_roundtrip_check(-1i128);
+        i128_roundtrip_check(-i128::from(u64::MAX));
+        i128_roundtrip_check(-i128::from(u64::MAX) - 1i128);
     }
 }
diff --git a/crates/astria-sequencer/src/app/tests_app/mod.rs b/crates/astria-sequencer/src/app/tests_app/mod.rs
index fcbe5dae5..a2b7c3ba5 100644
--- a/crates/astria-sequencer/src/app/tests_app/mod.rs
+++ b/crates/astria-sequencer/src/app/tests_app/mod.rs
@@ -982,7 +982,7 @@ async fn app_oracle_price_update_events_in_finalize_block() {
     app.commit(storage.clone()).await;
 
     let mut prices = std::collections::BTreeMap::new();
-    let price = Price::new(10000u128);
+    let price = Price::new(10000i128);
     let price_bytes = price.get().to_be_bytes().to_vec();
     let id_to_currency_pair = indexmap::indexmap! {
         id => CurrencyPairInfo{