refactor(conductor, relayer): remove astria-celestia-client #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
conductor
noot
approved these changes
Apr 30, 2024
Fraser999
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes
astria-celestia-clientas a direct dependency from astria-conductor and astria-sequencer-relayer.Background
We are no longer depending on any of the extension-traits defined in astria-celestia-client. It is merely used for constructing Celestia namespaces and reexporting of celestia crates.
Changes
namespace_v0*construction utilities toastria-corebehind acelestiafeature.astria-celestia-clientfromastria-conductorandastria-sequencer-relayer.astria-celestia-mockcrate remains until Restore black box tests removed from sequencer-relayer #1008 is done.Testing
Not necessary, just refactoring. All tests still pass.