fix(chart): secretObject when no env var usage #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroshiba
requested review from
WafflesVonMaple and
aajimal
and removed request for
WafflesVonMaple
WafflesVonMaple
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
secretObjectsin relayer chart, and theconfigmapwhich is unused whensecretProvideris enabledBackground
Secret objects are used for loading into k8s secrets and env vars, this is not something we are doing for the relayer chart as the secret is only accessed directly as a file.
Changes
secretObjectsfrom the provider.Testing
CI/CD, and changes have been manually made to deployments for devnet.