Skip to content

Commit 4204717

Browse files
committed
add acc test coverage
1 parent 517f4f4 commit 4204717

File tree

1 file changed

+18
-2
lines changed

1 file changed

+18
-2
lines changed

internal/provider/resources/resource_deployment_test.go

+18-2
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,15 @@ func TestAcc_ResourceDeploymentHybrid(t *testing.T) {
8484
IncludeEnvironmentVariables: false,
8585
SchedulerAu: 6,
8686
NodePoolId: nodePoolId,
87+
DesiredWorkloadIdentity: "arn:aws:iam::123456789:role/AirflowS3Logs-clmk2qqia000008mhff3ndjr0",
8788
}),
8889
Check: resource.ComposeTestCheckFunc(
8990
resource.TestCheckResourceAttr(resourceVar, "description", utils.TestResourceDescription),
9091
resource.TestCheckResourceAttr(resourceVar, "worker_queues.0.name", "default"),
9192
resource.TestCheckResourceAttr(resourceVar, "environment_variables.#", "0"),
9293
resource.TestCheckResourceAttr(resourceVar, "executor", "CELERY"),
9394
resource.TestCheckResourceAttr(resourceVar, "scheduler_au", "6"),
95+
resource.TestCheckResourceAttr(resourceVar, "workload_identity", "arn:aws:iam::123456789:role/AirflowS3Logs-clmk2qqia000008mhff3ndjr0"),
9496
// Check via API that deployment exists
9597
testAccCheckDeploymentExistence(t, deploymentName, false, true),
9698
),
@@ -194,13 +196,15 @@ func TestAcc_ResourceDeploymentStandard(t *testing.T) {
194196
SchedulerSize: string(platform.SchedulerMachineNameEXTRALARGE),
195197
IncludeEnvironmentVariables: false,
196198
WorkerQueuesStr: workerQueuesStr(""),
199+
DesiredWorkloadIdentity: "arn:aws:iam::123456789:role/AirflowS3Logs-clmk2qqia000008mhff3ndjr0",
197200
}),
198201
Check: resource.ComposeTestCheckFunc(
199202
resource.TestCheckResourceAttr(awsResourceVar, "description", utils.TestResourceDescription),
200203
resource.TestCheckResourceAttr(awsResourceVar, "scheduler_size", string(platform.SchedulerMachineNameEXTRALARGE)),
201204
resource.TestCheckResourceAttr(awsResourceVar, "worker_queues.0.name", "default"),
202205
resource.TestCheckNoResourceAttr(awsResourceVar, "environment_variables.0.key"),
203206
resource.TestCheckResourceAttr(awsResourceVar, "executor", "CELERY"),
207+
resource.TestCheckResourceAttr(awsResourceVar, "workload_identity", "arn:aws:iam::123456789:role/AirflowS3Logs-clmk2qqia000008mhff3ndjr0"),
204208
// Check via API that deployment exists
205209
testAccCheckDeploymentExistence(t, awsDeploymentName, true, true),
206210
),
@@ -722,6 +726,7 @@ type hybridDeploymentInput struct {
722726
SchedulerAu int
723727
NodePoolId string
724728
DuplicateWorkerQueues bool
729+
DesiredWorkloadIdentity string
725730
}
726731

727732
func hybridDeployment(input hybridDeploymentInput) string {
@@ -736,6 +741,10 @@ func hybridDeployment(input hybridDeploymentInput) string {
736741
} else {
737742
taskPodNodePoolIdStr = fmt.Sprintf(`task_pod_node_pool_id = "%v"`, input.NodePoolId)
738743
}
744+
desiredWorkloadIdentityStr := ""
745+
if input.DesiredWorkloadIdentity != "" {
746+
desiredWorkloadIdentityStr = input.DesiredWorkloadIdentity
747+
}
739748

740749
return fmt.Sprintf(`
741750
resource "astro_workspace" "%v_workspace" {
@@ -758,12 +767,13 @@ resource "astro_deployment" "%v" {
758767
%v
759768
%v
760769
%v
770+
%v
761771
}
762772
`,
763773
input.Name, input.Name, utils.TestResourceDescription,
764774
input.Name, input.Name, utils.TestResourceDescription,
765775
input.ClusterId, input.Executor, input.SchedulerAu, input.Name,
766-
envVarsStr(input.IncludeEnvironmentVariables), wqStr, taskPodNodePoolIdStr)
776+
envVarsStr(input.IncludeEnvironmentVariables), wqStr, taskPodNodePoolIdStr, desiredWorkloadIdentityStr)
767777
}
768778

769779
func developmentDeployment(scalingSpecDeploymentName, scalingSpec string) string {
@@ -791,6 +801,7 @@ type standardDeploymentInput struct {
791801
IsDevelopmentMode bool
792802
ScalingSpec string
793803
WorkerQueuesStr string
804+
DesiredWorkloadIdentity string
794805
}
795806

796807
func standardDeployment(input standardDeploymentInput) string {
@@ -816,6 +827,10 @@ func standardDeployment(input standardDeploymentInput) string {
816827
scalingSpecStr = input.ScalingSpec
817828
}
818829
}
830+
desiredWorkloadIdentityStr := ""
831+
if input.DesiredWorkloadIdentity != "" {
832+
desiredWorkloadIdentityStr = input.DesiredWorkloadIdentity
833+
}
819834
return fmt.Sprintf(`
820835
resource "astro_workspace" "%v_workspace" {
821836
name = "%s"
@@ -844,10 +859,11 @@ resource "astro_deployment" "%v" {
844859
%v
845860
%v
846861
%v
862+
%v
847863
}
848864
`,
849865
input.Name, input.Name, utils.TestResourceDescription, input.Name, input.Name, input.Description, input.Region, input.CloudProvider, input.Executor, input.IsDevelopmentMode, input.SchedulerSize, input.Name,
850-
envVarsStr(input.IncludeEnvironmentVariables), input.WorkerQueuesStr, scalingSpecStr)
866+
envVarsStr(input.IncludeEnvironmentVariables), input.WorkerQueuesStr, scalingSpecStr, desiredWorkloadIdentityStr)
851867
}
852868

853869
func standardDeploymentWithVariableName(input standardDeploymentInput) string {

0 commit comments

Comments
 (0)