Allow is_development_mode to be updated from true to false (#26)

Author: vandyliu

docs/resources/deployment.md

@@ -108,7 +108,7 @@ resource "astronomer_deployment" "hybrid" {
 - `cluster_id` (String) Deployment cluster identifier - required for 'HYBRID' and 'DEDICATED' deployments. If changing this value, the deployment will be recreated in the new cluster
 - `default_task_pod_cpu` (String) Deployment default task pod CPU - required for 'STANDARD' and 'DEDICATED' deployments
 - `default_task_pod_memory` (String) Deployment default task pod memory - required for 'STANDARD' and 'DEDICATED' deployments
-- `is_development_mode` (Boolean) Deployment development mode - required for 'STANDARD' and 'DEDICATED' deployments
+- `is_development_mode` (Boolean) Deployment development mode - required for 'STANDARD' and 'DEDICATED' deployments. If changing from 'False' to 'True', the deployment will be recreated
 - `is_high_availability` (Boolean) Deployment high availability - required for 'STANDARD' and 'DEDICATED' deployments
 - `region` (String) Deployment region - required for 'STANDARD' deployments. If changing this value, the deployment will be recreated in the new region
 - `resource_quota_cpu` (String) Deployment resource quota CPU - required for 'STANDARD' and 'DEDICATED' deployments

internal/clients/iam/api.gen.go

@@ -401,15 +401,14 @@ func (r *DeploymentResource) Update(
 			Executor:             platform.UpdateStandardDeploymentRequestExecutor(data.Executor.ValueString()),
 			IsCicdEnforced:       data.IsCicdEnforced.ValueBool(),
 			IsDagDeployEnabled:   data.IsDagDeployEnabled.ValueBool(),
-			// TODO: Uncomment once this https://github.com/astronomer/astro/pull/19471 is merged
-			//IsDevelopmentMode:    data.IsDevelopmentMode.ValueBoolPointer(),
-			IsHighAvailability:  data.IsHighAvailability.ValueBool(),
-			Name:                data.Name.ValueString(),
-			ResourceQuotaCpu:    data.ResourceQuotaCpu.ValueString(),
-			ResourceQuotaMemory: data.ResourceQuotaMemory.ValueString(),
-			SchedulerSize:       platform.UpdateStandardDeploymentRequestSchedulerSize(data.SchedulerSize.ValueString()),
-			Type:                platform.UpdateStandardDeploymentRequestTypeSTANDARD,
-			WorkspaceId:         data.WorkspaceId.ValueString(),
+			IsDevelopmentMode:    data.IsDevelopmentMode.ValueBoolPointer(),
+			IsHighAvailability:   data.IsHighAvailability.ValueBool(),
+			Name:                 data.Name.ValueString(),
+			ResourceQuotaCpu:     data.ResourceQuotaCpu.ValueString(),
+			ResourceQuotaMemory:  data.ResourceQuotaMemory.ValueString(),
+			SchedulerSize:        platform.UpdateStandardDeploymentRequestSchedulerSize(data.SchedulerSize.ValueString()),
+			Type:                 platform.UpdateStandardDeploymentRequestTypeSTANDARD,
+			WorkspaceId:          data.WorkspaceId.ValueString(),
 		}
 
 		// contact emails
@@ -459,15 +458,14 @@ func (r *DeploymentResource) Update(
 			Executor:             platform.UpdateDedicatedDeploymentRequestExecutor(data.Executor.ValueString()),
 			IsCicdEnforced:       data.IsCicdEnforced.ValueBool(),
 			IsDagDeployEnabled:   data.IsDagDeployEnabled.ValueBool(),
-			// TODO: Uncomment once this https://github.com/astronomer/astro/pull/19471 is merged
-			//IsDevelopmentMode:    data.IsDevelopmentMode.ValueBoolPointer(),
-			IsHighAvailability:  data.IsHighAvailability.ValueBool(),
-			Name:                data.Name.ValueString(),
-			ResourceQuotaCpu:    data.ResourceQuotaCpu.ValueString(),
-			ResourceQuotaMemory: data.ResourceQuotaMemory.ValueString(),
-			SchedulerSize:       platform.UpdateDedicatedDeploymentRequestSchedulerSize(data.SchedulerSize.ValueString()),
-			Type:                platform.UpdateDedicatedDeploymentRequestTypeDEDICATED,
-			WorkspaceId:         data.WorkspaceId.ValueString(),
+			IsDevelopmentMode:    data.IsDevelopmentMode.ValueBoolPointer(),
+			IsHighAvailability:   data.IsHighAvailability.ValueBool(),
+			Name:                 data.Name.ValueString(),
+			ResourceQuotaCpu:     data.ResourceQuotaCpu.ValueString(),
+			ResourceQuotaMemory:  data.ResourceQuotaMemory.ValueString(),
+			SchedulerSize:        platform.UpdateDedicatedDeploymentRequestSchedulerSize(data.SchedulerSize.ValueString()),
+			Type:                 platform.UpdateDedicatedDeploymentRequestTypeDEDICATED,
+			WorkspaceId:          data.WorkspaceId.ValueString(),
 		}
 
 		// contact emails

internal/clients/platform/api.gen.go

@@ -213,6 +213,25 @@ func TestAcc_ResourceDeploymentStandard(t *testing.T) {
 					testAccCheckDeploymentExistence(t, awsDeploymentName, true, true),
 				),
 			},
+			// Change is_development_mode back to false (will not recreate)
+			{
+				Config: astronomerprovider.ProviderConfig(t, true) + standardDeployment(standardDeploymentInput{
+					Name:                        awsDeploymentName,
+					Description:                 utils.TestResourceDescription,
+					Region:                      "us-east-1",
+					CloudProvider:               "AWS",
+					Executor:                    "KUBERNETES",
+					SchedulerSize:               "SMALL",
+					IncludeEnvironmentVariables: false,
+					IsDevelopmentMode:           false,
+				}),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr(awsResourceVar, "scheduler_size", "SMALL"),
+					resource.TestCheckResourceAttr(awsResourceVar, "is_development_mode", "false"),
+					// Check via API that deployment exists
+					testAccCheckDeploymentExistence(t, awsDeploymentName, true, true),
+				),
+			},
 			// Import existing deployment and check it is correctly imported - https://stackoverflow.com/questions/68824711/how-can-i-test-terraform-import-in-acceptance-tests
 			{
 				ResourceName:            awsResourceVar,

internal/provider/resources/resource_deployment.go

@@ -1,6 +1,7 @@
 package schemas
 
 import (
+	"context"
 	"regexp"
 
 	"github.com/astronomer/astronomer-terraform-provider/internal/clients/platform"
@@ -252,12 +253,20 @@ func DeploymentResourceSchemaAttributes() map[string]resourceSchema.Attribute {
 			Optional:            true,
 		},
 		"is_development_mode": resourceSchema.BoolAttribute{
-			MarkdownDescription: "Deployment development mode - required for 'STANDARD' and 'DEDICATED' deployments",
+			MarkdownDescription: "Deployment development mode - required for 'STANDARD' and 'DEDICATED' deployments. If changing from 'False' to 'True', the deployment will be recreated",
 			Optional:            true,
 			PlanModifiers: []planmodifier.Bool{
-				// Remove once this https://github.com/astronomer/astro/pull/19471 is merged
-				// Would recreate the deployment if this attribute changes
-				boolplanmodifier.RequiresReplaceIfConfigured(),
+				boolplanmodifier.RequiresReplaceIf(
+					func(_ context.Context, req planmodifier.BoolRequest, resp *boolplanmodifier.RequiresReplaceIfFuncResponse) {
+						prevIsDevelopmentMode := req.StateValue.ValueBool()
+						newIsDevelopmentMode := req.ConfigValue.ValueBool()
+						if prevIsDevelopmentMode == false && newIsDevelopmentMode == true {
+							resp.RequiresReplace = true
+						}
+					},
+					"Converting a non-development mode deployment to a development mode deployment is not allowed. Therefore, the deployment will be recreated as a development-mode deployment",
+					"Converting a non-development mode deployment to a development mode deployment is not allowed. Therefore, the deployment will be recreated as a development-mode deployment",
+				),
 			},
 		},
 		"resource_quota_cpu": resourceSchema.StringAttribute{