Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work with newer Catalyst versions #65

Open
kaandocal opened this issue Aug 19, 2024 · 9 comments
Open

Update to work with newer Catalyst versions #65

kaandocal opened this issue Aug 19, 2024 · 9 comments

Comments

@kaandocal
Copy link
Contributor

No description provided.

@kaandocal kaandocal changed the title Update to newer Catalyst versions Update to work with newer Catalyst versions Aug 19, 2024
@TorkelE
Copy link

TorkelE commented Dec 9, 2024

Do you have any hunch of when/if this is planned? I am trying to use this in conjecture with MTK/Catalyst, and it would be good to be able to do this on the latest version.

@augustinas1
Copy link
Owner

HI @TorkelE, hoping to get things updated in the next couple of weeks, sorry for the delay!

@kaandocal
Copy link
Contributor Author

I've created a fork here - it will print superfluous output for now, but the tests work for Catalyst v14 (except latexify).

@kaandocal
Copy link
Contributor Author

The relatively new Catalyst API (species indexed by name, not number) will take a bit more work to implement, see the other currently active issue.

@TorkelE
Copy link

TorkelE commented Dec 10, 2024

Sounds great, looking forward to it :)

One though I had, do you ever do anything but

u0 = [...]
u0 = deterministic_IC(u0, moment_eqs)
oprob = ODEProblem(moment_eqs, u0, tspan, ps)

?

I.e. is there a reason that the deterministic_IC call could not be integrated into the ODEProblem call?

@augustinas1
Copy link
Owner

The function deterministic_IC is supposed to construct deterministic initial conditions so that the molecule numbers at initial time take the specified integer values with probability one. Although this is the most commonly used case, one could consider alternative custom initial conditions, and for this reason I chose to keep the initial condition setup general. It's a good question though, will have a think about integrating deterministic_IC by default but leaving alternative options possible too.

@TorkelE
Copy link

TorkelE commented Jan 19, 2025

Hello, just checking whether updates on if an update is planned? It is a good package, and it would be nice if it remained useful for the wider community. If we can get this to work with latest Catalysts versions and you are OK with it, I was hoping to write a small example of how it could be used and add to the Catalyst docs. I could then link that directly to this package so people could go here for more info. That might also help give MomentClosure.jl more users as well.

@augustinas1
Copy link
Owner

Hi, sorry, it's been a very busy time, but an update is definitely planned. Hopefully I'll be able to get around to patching it up next week. Thanks for your initiative (and patience) Torkel!

@TorkelE
Copy link

TorkelE commented Jan 24, 2025

No worries! Yeah, things are always busier than one would hope. Looking forward to the update, whenever it drops :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants