Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navurl field in MRG entries have wrong values #2

Open
brianorwhatever opened this issue Feb 13, 2023 · 1 comment
Open

navurl field in MRG entries have wrong values #2

brianorwhatever opened this issue Feb 13, 2023 · 1 comment

Comments

@brianorwhatever
Copy link

Original Issue

The contents of the navurl field in an MRG entry is specified as the "path, relative to the URL as specified in the website field in the scope section of the SAF (that lives in the scopedir as specified in the scopes section of the MRG), where the rendered version of the curated text is located."

A bit more pragmatically put: the URL that is the concatenation of the website field (from the SAF) and the navurl field (from an MRG entry) must locate the rendered version of the CText that the MRG entry represents.

This is currently not the case: the navurl fields not only contain a full URL, but they also do not point to a rendered version of the CText, but to the actual CText itself.

The current specs are ambivalent (see essif-lab/framework#135), as the specification of the website field says that it points to the home page of the (rendered) website of the scope. If that were true, concatenation of website and navurl would not produce a link that would (always) work. The documentation of website will be updated so that the concatenation will work.

If you happen to be the person that fixes this issue, and you think it is appropriate to rename the website field, please go ahead and ping me about it, and mention this explicitly in the commit.

@brianorwhatever
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant