Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compilation with latest TLS >= 1.3 and remove deprecated crypto packages #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix compilation with latest TLS >= 1.3 and remove deprecated crypto packages #4

wants to merge 1 commit into from

Conversation

vincenthz
Copy link

@vincenthz vincenthz commented Apr 19, 2016 •
edited
Loading

  • remove deprecated cryptohash and cryptorandom in favor of cryptonite
  • remove base16-bytestring in favor of memory that can convert more elaborate type like (HMAC)
  • adapt to work with tls 1.3 (removal of the rng parameter)

@avieth
Copy link
Owner

avieth commented Apr 19, 2016

Thanks a lot for this! Just one request before merging: seems base64-bytestring and memory overlap. Can we completely replace the former and remove it from the build depends?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincenthz @avieth