-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set GOCACHE under OUT_DIR #603
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
==========================================
- Coverage 95.80% 92.69% -3.11%
==========================================
Files 61 67 +6
Lines 8143 9772 +1629
Branches 0 9772 +9772
==========================================
+ Hits 7801 9058 +1257
- Misses 342 429 +87
- Partials 0 285 +285 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
env::set_var( | ||
"GOCACHE", | ||
self.out_dir.join(Self::GOCACHE_DIR_NAME).as_os_str(), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Ideally if the user has this environment variable set to something we don't override it.
Issues
Addresses:
aws-lc-fips-sys
fail to build docs on docs.rs #600Context
GOCACHE
environment variable determines the location for this directory.Description of changes:
.cache
directory.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.