Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GOCACHE under OUT_DIR #603

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Set GOCACHE under OUT_DIR #603

merged 2 commits into from
Nov 19, 2024

Conversation

justsmth
Copy link
Contributor

Issues

Addresses:

Context

...
[INFO] [stderr]   --- stderr
[INFO] [stderr]   failed to initialize build cache at /.cache/go-build: mkdir /.cache: permission denied
...

Description of changes:

  • Sets the GOCACHE environment variable to be beneath ${OUT_DIR}, in which the Go compiler should have permission to create its .cache directory.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner November 19, 2024 13:59
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (c358484) to head (4ccf2d7).
Report is 116 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   95.80%   92.69%   -3.11%     
==========================================
  Files          61       67       +6     
  Lines        8143     9772    +1629     
  Branches        0     9772    +9772     
==========================================
+ Hits         7801     9058    +1257     
- Misses        342      429      +87     
- Partials        0      285     +285     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Comment on lines +95 to +98
env::set_var(
"GOCACHE",
self.out_dir.join(Self::GOCACHE_DIR_NAME).as_os_str(),
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Ideally if the user has this environment variable set to something we don't override it.

@justsmth justsmth merged commit c236deb into aws:main Nov 19, 2024
241 of 246 checks passed
@justsmth justsmth deleted the fips-docs.rs branch November 19, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants