Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RustRover insight #671

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Fix RustRover insight #671

merged 1 commit into from
Jan 23, 2025

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jan 23, 2025

Description of changes:

  • RustRover appears unable to understand use aws_lc::XXX, but is fine with use crate::aws_lc::XXX.
    • To correct this I used the IDE to do a find/replace across everything under aws-lc-rs/src/.

Testing

  • Verified the IDE no longer complains about symbols used from aws_lc.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner January 23, 2025 14:06
@justsmth justsmth requested a review from skmcgrail January 23, 2025 14:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (c358484) to head (0f87634).
Report is 157 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   95.80%   92.84%   -2.96%     
==========================================
  Files          61       68       +7     
  Lines        8143     9747    +1604     
  Branches        0     9747    +9747     
==========================================
+ Hits         7801     9050    +1249     
- Misses        342      407      +65     
- Partials        0      290     +290     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit 76bcc06 into aws:main Jan 23, 2025
261 of 263 checks passed
@justsmth justsmth deleted the fix-rust-rover branch January 23, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants