Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to support illumos #709

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Try to support illumos #709

wants to merge 2 commits into from

Conversation

LecrisUT
Copy link

I don't have the expertise to actually chase this down, but wanted to point out the current issue with trying to build for illumos. This issue is a blocker for upgrading rustls package in atuin and to move away from ring.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@LecrisUT LecrisUT requested a review from a team as a code owner February 26, 2025 17:07
@LecrisUT
Copy link
Author

In short the issue is:

   --- stderr
  Evaluating: AWS_LC_SYS_EXTERNAL_BINDGEN='0'
  Parsed: AWS_LC_SYS_EXTERNAL_BINDGEN=false
  Failure invoking external bindgen! 
  bindgen-PARAMS: --prefix-link-name aws_lc_0_26_0_ --allowlist-file .*(/|\\)openssl((/|\\)[^/\\]+)+\.h --allowlist-file .*(/|\\)rust_wrapper\.h --rustified-enum point_conversion_form_t --default-macro-constant-type signed --with-derive-default --with-derive-partialeq --with-derive-eq --raw-line 
  // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
  // SPDX-License-Identifier: Apache-2.0 OR ISC
   --generate functions,types,vars,methods,constructors,destructors /home/runner/work/aws-lc-rs/aws-lc-rs/aws-lc-sys/include/rust_wrapper.h --rust-target 1.59 --output /target/x86_64-unknown-illumos/release/build/aws-lc-sys-d08023f950b0ca18/out/bindings.rs --formatter rustfmt -- -I /home/runner/work/aws-lc-rs/aws-lc-rs/aws-lc-sys/include -I /home/runner/work/aws-lc-rs/aws-lc-rs/aws-lc-sys/aws-lc/include
  bindgen-STDOUT: 
  bindgen-STDERR: /usr/include/stdint.h:26:10: fatal error: 'bits/libc-header-start.h' file not found
  Unable to generate bindings: clang diagnosed error: /usr/include/stdint.h:26:10: fatal error: 'bits/libc-header-start.h' file not found
  thread 'main' panicked at aws-lc-sys/builder/main.rs:643:5:
  aws-lc-sys build failed. Please enable the 'bindgen' feature on aws-lc-rs or aws-lc-sys.For more information, see the aws-lc-rs User Guide: https://aws.github.io/aws-lc-rs/index.html
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Specifically

/usr/include/stdint.h:26:10: fatal error: 'bits/libc-header-start.h' file not found

@justsmth
Copy link
Contributor

Thanks for the PR! We'll look into any failure that occurs.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (c358484) to head (250da9c).
Report is 177 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
- Coverage   95.80%   92.89%   -2.91%     
==========================================
  Files          61       70       +9     
  Lines        8143     9538    +1395     
  Branches        0     9538    +9538     
==========================================
+ Hits         7801     8860    +1059     
- Misses        342      412      +70     
- Partials        0      266     +266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants