You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Apache Arrow uses aws-sdk-cpp for S3 support. Apache Arrow uses system aws-sdk-cpp or bundled aws-sdk-cpp by ExternalProject_Add()/FetchContent.
Apache Arrow supports mingw-w64 based environments. If aws-sdk-cpp supports mingw-w64, Apache Arrow don't need to apply patches with ExternalProject_Add()/FetchContent.
Proposed Solution
How about merging the patches in MSYS2?
Other Information
No response
Acknowledgements
I may be able to implement this feature request
This feature might incur a breaking change
The text was updated successfully, but these errors were encountered:
Hi @kou,
Thank you for submitting this issue and thank you for providing this patches.
We are not against adding mingw support. The main reason the previous PRs were not merged is because we don't have this platform on our internal CI build system, so we were not able to ensure we would not break it, so we could not claim this target as supported.
Would it be possible for you to provide an example how you build the SDK on mingw-w64? I.e. the set of commands executed, and the prerequisites required so we could reproduce the build.
Thanks for sharing the details of the past reject. I understand your judgement.
Would it be possible for you to provide an example how you build the SDK on mingw-w64? I.e. the set of commands executed, and the prerequisites required so we could reproduce the build.
Sure. I'll provide a GitHub Actions workflow for it. It'll explain what you need for your internal CI build system.
Describe the feature
#1836 was raised and rejected in 2022. Is this policy still valid?
MSYS2 has patches for this:
Use Case
I'm an Apache Arrow https://arrow.apache.org/ developer.
Apache Arrow uses aws-sdk-cpp for S3 support. Apache Arrow uses system aws-sdk-cpp or bundled aws-sdk-cpp by
ExternalProject_Add()
/FetchContent
.Apache Arrow supports mingw-w64 based environments. If aws-sdk-cpp supports mingw-w64, Apache Arrow don't need to apply patches with
ExternalProject_Add()
/FetchContent
.Proposed Solution
How about merging the patches in MSYS2?
Other Information
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: