Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw-w64 support #3315

Open
1 of 2 tasks
kou opened this issue Feb 26, 2025 · 3 comments
Open
1 of 2 tasks

mingw-w64 support #3315

kou opened this issue Feb 26, 2025 · 3 comments
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@kou
Copy link

kou commented Feb 26, 2025

Describe the feature

#1836 was raised and rejected in 2022. Is this policy still valid?

MSYS2 has patches for this:

Use Case

I'm an Apache Arrow https://arrow.apache.org/ developer.

Apache Arrow uses aws-sdk-cpp for S3 support. Apache Arrow uses system aws-sdk-cpp or bundled aws-sdk-cpp by ExternalProject_Add()/FetchContent.

Apache Arrow supports mingw-w64 based environments. If aws-sdk-cpp supports mingw-w64, Apache Arrow don't need to apply patches with ExternalProject_Add()/FetchContent.

Proposed Solution

How about merging the patches in MSYS2?

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@kou kou added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 26, 2025
@SergeyRyabinin
Copy link
Contributor

Hi @kou,
Thank you for submitting this issue and thank you for providing this patches.
We are not against adding mingw support. The main reason the previous PRs were not merged is because we don't have this platform on our internal CI build system, so we were not able to ensure we would not break it, so we could not claim this target as supported.

Would it be possible for you to provide an example how you build the SDK on mingw-w64? I.e. the set of commands executed, and the prerequisites required so we could reproduce the build.

Best regards,
Sergey

@kou
Copy link
Author

kou commented Feb 28, 2025

Thanks for sharing the details of the past reject. I understand your judgement.

Would it be possible for you to provide an example how you build the SDK on mingw-w64? I.e. the set of commands executed, and the prerequisites required so we could reproduce the build.

Sure. I'll provide a GitHub Actions workflow for it. It'll explain what you need for your internal CI build system.

@kou
Copy link
Author

kou commented Feb 28, 2025

Could you check #3319?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants