Skip to content

Commit

Permalink
Merge pull request #42 from ba-st/pharo11
Browse files Browse the repository at this point in the history
Add Pharo 11 support
  • Loading branch information
gcotelli authored May 25, 2023
2 parents feb3f3d + d1c2bcb commit 5de0394
Show file tree
Hide file tree
Showing 10 changed files with 20 additions and 20 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/loading-groups.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
smalltalk: [ Pharo64-10, Pharo64-9.0, Pharo64-8.0 ]
smalltalk: [ Pharo64-11, Pharo64-10, Pharo64-9.0, Pharo64-8.0 ]
load-spec: [ deployment, tests, development, tools ]
name: ${{ matrix.smalltalk }} + ${{ matrix.load-spec }}
services:
Expand All @@ -18,7 +18,7 @@ jobs:
- 5672:5672
options: --health-cmd "rabbitmqctl node_health_check" --health-interval 10s --health-timeout 5s --health-retries 5
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: hpi-swa/setup-smalltalkCI@v1
with:
smalltalk-image: ${{ matrix.smalltalk }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/markdown-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: markdownlint
uses: reviewdog/action-markdownlint@v0.1
uses: reviewdog/action-markdownlint@v0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
fail_on_error: true
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
fail-fast: false
matrix:
smalltalk: [ Pharo64-10, Pharo64-9.0, Pharo64-8.0 ]
smalltalk: [ Pharo64-11, Pharo64-10, Pharo64-9.0, Pharo64-8.0 ]
name: ${{ matrix.smalltalk }}
services:
rabbitmq:
Expand All @@ -18,7 +18,7 @@ jobs:
- 5672:5672
options: --health-cmd "rabbitmqctl node_health_check" --health-interval 10s --health-timeout 5s --health-retries 5
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: hpi-swa/setup-smalltalkCI@v1
with:
smalltalk-image: ${{ matrix.smalltalk }}
Expand All @@ -31,3 +31,4 @@ jobs:
uses: codecov/codecov-action@v3
with:
name: Unit-Tests-${{ matrix.smalltalk }}
token: ${{ secrets.CODECOV_TOKEN }}
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Ansible is a AMQP client library for Smalltalk supporting 0-8 and 0-9-1
[![Pharo 8.0](https://img.shields.io/badge/Pharo-8.0-informational)](https://pharo.org)
[![Pharo 9.0](https://img.shields.io/badge/Pharo-9.0-informational)](https://pharo.org)
[![Pharo 10](https://img.shields.io/badge/Pharo-10-informational)](https://pharo.org)
[![Pharo 11](https://img.shields.io/badge/Pharo-10-informational)](https://pharo.org)

An [Ansible](https://en.wikipedia.org/wiki/Ansible) is a fictional device
capable of near-instantaneous communication. It can send and receive message
Expand Down
4 changes: 2 additions & 2 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Contributing

There's several ways to contribute to the project: reporting bugs, sending
There are several ways to contribute to the project: reporting bugs, sending
feedback, proposing ideas for new features, fixing or adding documentation,
promoting the project, or even contributing code.

## Reporting issues

You can report issues [here](https://github.com/<OWNER>/<REPO_NAME>/issues/new)
You can report issues [here](https://github.com/ba-st/Ansible/issues/new)

## Contributing Code

Expand Down
2 changes: 1 addition & 1 deletion docs/tutorials/PublishSubscribe.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ After sending a couple of messages the subscriber's Transcript will look like th

![Transcript with received messages](publish_subscribe_message_received_transcript.png)

Also, you'll receive a notification for every message like this one
Also, you'll receive a notification for every message like this one

![Message received toast](publish_subscribe_message_received_toast.png)

Expand Down
2 changes: 1 addition & 1 deletion docs/tutorials/Routing.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ This communication pattern allows sending messages to a specific route.
![Diagram of routing](routing.png)

In this tutorial, you'll refine the logging example you did [previously](PublishSubscribe.md)
by selectively sending some of the log messages to a specific error logger.
by selectively sending some log messages to a specific error logger.

Log messages have a severity: `info`, `warning` or `error`.

Expand Down
16 changes: 8 additions & 8 deletions docs/tutorials/WorkerQueue.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,16 @@ channel declareQueueApplying: [ :queue | queue name: 'task_queue' ].
channel prefetchCount: 1.
````

The `channel prefetchCount: 1` directs RabbitMQ to wait for an acknowledge of
The `channel prefetchCount: 1` directs RabbitMQ to wait for an acknowledgment of
the last message before sending another to the worker. Without this, the broker
will send the messages to the worker as soon as they enter the queue (regardless
of whether the worker is ready to receive more messages).

Now you'll create a subscription to the queue. First you a register a callback,
Now you'll create a subscription to the queue. First you register a callback,
which will simulate running a task by creating a delay of n seconds, where n
is the amount of dots in the message. It will open a toast message for each
received message by the consumer showing the time it took, and it will send
the acknowledge to the broker.
the acknowledgment to the broker.

```smalltalk
channel
Expand All @@ -72,9 +72,9 @@ channel
].
```

If the broker does not receive the acknowledge it will wait forever since there
is no timeout. If the connection dies RabbitMQ will re-queue the message and
try to send it again.
If the broker does not receive the acknowledgment it will wait forever since there
is no timeout. If the connection dies RabbitMQ will re-queue the message and
try to send it again.

## Spawning workers

Expand Down Expand Up @@ -164,8 +164,8 @@ On the images acting as worker open a Playground and evaluate the corresponding
script. Now, on the third one inspect the producer script on a Playground. This
will send your first message.

Since you inspected the script, an inspector on a instance of channel will open.
To send more messages to the workers send `#basicPublish:exchange:routingKey:`
Since you inspected the script, an inspector on an instance of channel will open.
To send more messages to the workers send `#basicPublish:exchange:routingKey:`
to it.

After each message sent you should see a toast notification on one your worker
Expand Down
2 changes: 0 additions & 2 deletions source/Ansible-Protocol-Core/AmqpProtocolHeaderFrame.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ AmqpProtocolHeaderFrame >> readFrom: connection length: length [

| codec |

length inspect.

"length is four bytes big-endian: $P followed by the first three bytes of the version spec."
codec := connection codec.
( length byteAt: 4 ) = $P asciiValue
Expand Down
2 changes: 1 addition & 1 deletion source/BaselineOfAnsible/BaselineOfAnsible.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ BaselineOfAnsible >> setUpDependencies: spec [

spec
baseline: 'XMLParser'
with: [ spec repository: 'github://pharo-contributions/XML-XMLParser:3.5.0/src' ];
with: [ spec repository: 'github://pharo-contributions/XML-XMLParser:master/src' ];
project: 'XMLParser-Core' copyFrom: 'XMLParser' with: [ spec loads: #( 'Core' ) ].

spec
Expand Down

0 comments on commit 5de0394

Please sign in to comment.