diff --git a/.github/workflows/loading-groups.yml b/.github/workflows/loading-groups.yml index d027b785..2b0f9caa 100644 --- a/.github/workflows/loading-groups.yml +++ b/.github/workflows/loading-groups.yml @@ -8,7 +8,7 @@ jobs: strategy: fail-fast: false matrix: - smalltalk: [ Pharo64-10, Pharo64-9.0, Pharo64-8.0 ] + smalltalk: [ Pharo64-11, Pharo64-10, Pharo64-9.0, Pharo64-8.0 ] load-spec: [ deployment, tests, development, tools ] name: ${{ matrix.smalltalk }} + ${{ matrix.load-spec }} services: @@ -18,7 +18,7 @@ jobs: - 5672:5672 options: --health-cmd "rabbitmqctl node_health_check" --health-interval 10s --health-timeout 5s --health-retries 5 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: hpi-swa/setup-smalltalkCI@v1 with: smalltalk-image: ${{ matrix.smalltalk }} diff --git a/.github/workflows/markdown-lint.yml b/.github/workflows/markdown-lint.yml index f59b0594..b21e7e07 100644 --- a/.github/workflows/markdown-lint.yml +++ b/.github/workflows/markdown-lint.yml @@ -7,7 +7,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: markdownlint - uses: reviewdog/action-markdownlint@v0.1 + uses: reviewdog/action-markdownlint@v0 with: github_token: ${{ secrets.GITHUB_TOKEN }} fail_on_error: true diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 04a339e8..a90a34d4 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -9,7 +9,7 @@ jobs: strategy: fail-fast: false matrix: - smalltalk: [ Pharo64-10, Pharo64-9.0, Pharo64-8.0 ] + smalltalk: [ Pharo64-11, Pharo64-10, Pharo64-9.0, Pharo64-8.0 ] name: ${{ matrix.smalltalk }} services: rabbitmq: @@ -18,7 +18,7 @@ jobs: - 5672:5672 options: --health-cmd "rabbitmqctl node_health_check" --health-interval 10s --health-timeout 5s --health-retries 5 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: hpi-swa/setup-smalltalkCI@v1 with: smalltalk-image: ${{ matrix.smalltalk }} @@ -31,3 +31,4 @@ jobs: uses: codecov/codecov-action@v3 with: name: Unit-Tests-${{ matrix.smalltalk }} + token: ${{ secrets.CODECOV_TOKEN }} diff --git a/README.md b/README.md index 0de13030..bf14b8e3 100644 --- a/README.md +++ b/README.md @@ -14,6 +14,7 @@ Ansible is a AMQP client library for Smalltalk supporting 0-8 and 0-9-1 [![Pharo 8.0](https://img.shields.io/badge/Pharo-8.0-informational)](https://pharo.org) [![Pharo 9.0](https://img.shields.io/badge/Pharo-9.0-informational)](https://pharo.org) [![Pharo 10](https://img.shields.io/badge/Pharo-10-informational)](https://pharo.org) +[![Pharo 11](https://img.shields.io/badge/Pharo-10-informational)](https://pharo.org) An [Ansible](https://en.wikipedia.org/wiki/Ansible) is a fictional device capable of near-instantaneous communication. It can send and receive message diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 198f583e..6f283ddf 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -1,12 +1,12 @@ # Contributing -There's several ways to contribute to the project: reporting bugs, sending +There are several ways to contribute to the project: reporting bugs, sending feedback, proposing ideas for new features, fixing or adding documentation, promoting the project, or even contributing code. ## Reporting issues -You can report issues [here](https://github.com///issues/new) +You can report issues [here](https://github.com/ba-st/Ansible/issues/new) ## Contributing Code diff --git a/docs/tutorials/PublishSubscribe.md b/docs/tutorials/PublishSubscribe.md index 65de1aa0..9fd17fe6 100644 --- a/docs/tutorials/PublishSubscribe.md +++ b/docs/tutorials/PublishSubscribe.md @@ -141,7 +141,7 @@ After sending a couple of messages the subscriber's Transcript will look like th ![Transcript with received messages](publish_subscribe_message_received_transcript.png) -Also, you'll receive a notification for every message like this one +Also, you'll receive a notification for every message like this one ![Message received toast](publish_subscribe_message_received_toast.png) diff --git a/docs/tutorials/Routing.md b/docs/tutorials/Routing.md index d28e02be..f729b976 100644 --- a/docs/tutorials/Routing.md +++ b/docs/tutorials/Routing.md @@ -7,7 +7,7 @@ This communication pattern allows sending messages to a specific route. ![Diagram of routing](routing.png) In this tutorial, you'll refine the logging example you did [previously](PublishSubscribe.md) - by selectively sending some of the log messages to a specific error logger. + by selectively sending some log messages to a specific error logger. Log messages have a severity: `info`, `warning` or `error`. diff --git a/docs/tutorials/WorkerQueue.md b/docs/tutorials/WorkerQueue.md index 8957e246..3ad3dba0 100644 --- a/docs/tutorials/WorkerQueue.md +++ b/docs/tutorials/WorkerQueue.md @@ -45,16 +45,16 @@ channel declareQueueApplying: [ :queue | queue name: 'task_queue' ]. channel prefetchCount: 1. ```` -The `channel prefetchCount: 1` directs RabbitMQ to wait for an acknowledge of +The `channel prefetchCount: 1` directs RabbitMQ to wait for an acknowledgment of the last message before sending another to the worker. Without this, the broker will send the messages to the worker as soon as they enter the queue (regardless of whether the worker is ready to receive more messages). -Now you'll create a subscription to the queue. First you a register a callback, +Now you'll create a subscription to the queue. First you register a callback, which will simulate running a task by creating a delay of n seconds, where n is the amount of dots in the message. It will open a toast message for each received message by the consumer showing the time it took, and it will send - the acknowledge to the broker. + the acknowledgment to the broker. ```smalltalk channel @@ -72,9 +72,9 @@ channel ]. ``` -If the broker does not receive the acknowledge it will wait forever since there - is no timeout. If the connection dies RabbitMQ will re-queue the message and - try to send it again. +If the broker does not receive the acknowledgment it will wait forever since there +is no timeout. If the connection dies RabbitMQ will re-queue the message and +try to send it again. ## Spawning workers @@ -164,8 +164,8 @@ On the images acting as worker open a Playground and evaluate the corresponding script. Now, on the third one inspect the producer script on a Playground. This will send your first message. -Since you inspected the script, an inspector on a instance of channel will open. - To send more messages to the workers send `#basicPublish:exchange:routingKey:` +Since you inspected the script, an inspector on an instance of channel will open. + To send more messages to the workers send `#basicPublish:exchange:routingKey:` to it. After each message sent you should see a toast notification on one your worker diff --git a/source/Ansible-Protocol-Core/AmqpProtocolHeaderFrame.class.st b/source/Ansible-Protocol-Core/AmqpProtocolHeaderFrame.class.st index 8a140925..73ac8904 100644 --- a/source/Ansible-Protocol-Core/AmqpProtocolHeaderFrame.class.st +++ b/source/Ansible-Protocol-Core/AmqpProtocolHeaderFrame.class.st @@ -24,8 +24,6 @@ AmqpProtocolHeaderFrame >> readFrom: connection length: length [ | codec | - length inspect. - "length is four bytes big-endian: $P followed by the first three bytes of the version spec." codec := connection codec. ( length byteAt: 4 ) = $P asciiValue diff --git a/source/BaselineOfAnsible/BaselineOfAnsible.class.st b/source/BaselineOfAnsible/BaselineOfAnsible.class.st index d29f6eaf..2f750d2d 100644 --- a/source/BaselineOfAnsible/BaselineOfAnsible.class.st +++ b/source/BaselineOfAnsible/BaselineOfAnsible.class.st @@ -32,7 +32,7 @@ BaselineOfAnsible >> setUpDependencies: spec [ spec baseline: 'XMLParser' - with: [ spec repository: 'github://pharo-contributions/XML-XMLParser:3.5.0/src' ]; + with: [ spec repository: 'github://pharo-contributions/XML-XMLParser:master/src' ]; project: 'XMLParser-Core' copyFrom: 'XMLParser' with: [ spec loads: #( 'Core' ) ]. spec