-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design/Art: Better REPL Twitter Embed #1383
Comments
I'm wondering how you could generate a picture of the code (without a backend?). Either we should remove the cover because it's annoying or an picture with "click to see the REPL" or something. |
@hzoo I want to do it! |
Awesome. Since I didn't really go into the solutions - do you understand the issue though? It's just that either we
I think removing the image for social media seems reasonable (simple, easiest) |
@hzoo Even I feel the same that removing the pictures for repl is the best possible solution. So should I implement it? |
Great, sounds good. I believe the image is from https://github.com/babel/website/blob/master/_includes/head.html, but not sure how you remove it from the repl link (I guess another question is whether we would want to remove it entirely) I guess jekyll may have a way to check the Oh wait I already see a |
@hzoo I agree, doing it in jeklly by conditionally removing the meta-tag for repl links would be the ideal solution in my mind |
@hzoo I feel the error is because of lines 31, 33, 37, these would also need a repl check. |
https://twitter.com/left_pad/status/909088586473115648
When you post a link to the repl on twitter and elsewhere, we should change what it shows? Maybe it should just not have the same picture/etc (just remove it entirely), it's annoying?
Example
The text was updated successfully, but these errors were encountered: