Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design/Art: Better REPL Twitter Embed #1383

Open
hzoo opened this issue Sep 18, 2017 · 7 comments
Open

Design/Art: Better REPL Twitter Embed #1383

hzoo opened this issue Sep 18, 2017 · 7 comments

Comments

@hzoo
Copy link
Member

hzoo commented Sep 18, 2017

https://twitter.com/left_pad/status/909088586473115648

When you post a link to the repl on twitter and elsewhere, we should change what it shows? Maybe it should just not have the same picture/etc (just remove it entirely), it's annoying?

Example

screen shot 2017-09-28 at 7 00 00 am

@xtuc
Copy link
Member

xtuc commented Sep 25, 2017

I'm wondering how you could generate a picture of the code (without a backend?).

Either we should remove the cover because it's annoying or an picture with "click to see the REPL" or something.

@asthas
Copy link

asthas commented Sep 28, 2017

@hzoo I want to do it!

@hzoo
Copy link
Member Author

hzoo commented Sep 28, 2017

Awesome. Since I didn't really go into the solutions - do you understand the issue though? It's just that either we

  • remove a picture entirely for the /repl URLs
  • somehow generate an image (seems unlikely)
  • use a different image just for those URLs

I think removing the image for social media seems reasonable (simple, easiest)

@asthas
Copy link

asthas commented Sep 28, 2017

@hzoo Even I feel the same that removing the pictures for repl is the best possible solution. So should I implement it?

@hzoo
Copy link
Member Author

hzoo commented Sep 28, 2017

Great, sounds good.

I believe the image is from https://github.com/babel/website/blob/master/_includes/head.html, but not sure how you remove it from the repl link (I guess another question is whether we would want to remove it entirely)

I guess jekyll may have a way to check the page.url first

Oh wait I already see a {% if page.permalink != '/repl/' %}

@asthas
Copy link

asthas commented Sep 28, 2017

@hzoo I agree, doing it in jeklly by conditionally removing the meta-tag for repl links would be the ideal solution in my mind

@asthas
Copy link

asthas commented Sep 28, 2017

@hzoo I feel the error is because of lines 31, 33, 37, these would also need a repl check.

@hzoo hzoo changed the title REPL social media embed Design/Art: Better REPL Twitter Embed Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants