Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt ErrSigHeightOutdated when sending finality vote #290

Closed
gitferry opened this issue Jan 17, 2025 · 0 comments · Fixed by #372
Closed

Adapt ErrSigHeightOutdated when sending finality vote #290

gitferry opened this issue Jan 17, 2025 · 0 comments · Fixed by #372
Assignees
@Vvaradinov
Labels
phase-2-readiness

Comments

@gitferry
Copy link
Member

gitferry commented Jan 17, 2025 •
edited
Loading

If a block is finalized and timestamped then babylon will reject further finality votes ref. Finality provider should consider this as expected, i.e., here when sending finality sig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vvaradinov Vvaradinov

Labels
phase-2-readiness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add expected errors to when sending finality signatures babylonlabs-io/finality-provider
2 participants
@gitferry @Vvaradinov