Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button styles #368

Closed
Tracked by #330
forsbergplustwo opened this issue Feb 9, 2024 · 5 comments
Closed
Tracked by #330

Button styles #368

forsbergplustwo opened this issue Feb 9, 2024 · 5 comments
Assignees
Milestone

Comments

@forsbergplustwo
Copy link
Collaborator

Button styles need aligning with the new v12 styles. Default and Primary are ok, but we need to check all the other variants.

@forsbergplustwo forsbergplustwo added this to the v2.0 milestone Feb 9, 2024
@forsbergplustwo forsbergplustwo mentioned this issue Feb 9, 2024
19 tasks
@kirillplatonov
Copy link
Collaborator

@forsbergplustwo some CSS overrides seems to cause the issue. Without them buttons looks the same:
CleanShot 2024-02-09 at 20 27 19@2x
CleanShot 2024-02-09 at 20 28 20@2x
CleanShot 2024-02-09 at 20 28 25@2x

@forsbergplustwo
Copy link
Collaborator Author

Yeah, I'll scope that to Banner, Modal, Card etc. that want the button text larger and bold. But this task is more about the other button styles, like Critical/Destroy etc.

@forsbergplustwo
Copy link
Collaborator Author

EDIT: Just realized I'm seeing the "Mobile" styling of the buttons, because I've got 2 windows side by side on my laptop. So I'll move those parts to a @media query instead 😅

We still need to check on the other button styles though.

@kirillplatonov
Copy link
Collaborator

Got it 🙂

@forsbergplustwo forsbergplustwo self-assigned this Feb 10, 2024
@forsbergplustwo
Copy link
Collaborator Author

@kirillplatonov - This one is now done.. see #383 for screenshots 🎉

Note: The new Polaris v12 does not have "outline" buttons, so I've silently dropped the class from being added in the component for now, making them a "normal" button:

# "Polaris-Button--outline": outline,

Not sure if there's a better fallback for these as I don't remember using them anywhere, but let me know if you think it should be done different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants