-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button styles #368
Comments
@forsbergplustwo some CSS overrides seems to cause the issue. Without them buttons looks the same: |
Yeah, I'll scope that to Banner, Modal, Card etc. that want the button text larger and bold. But this task is more about the other button styles, like Critical/Destroy etc. |
EDIT: Just realized I'm seeing the "Mobile" styling of the buttons, because I've got 2 windows side by side on my laptop. So I'll move those parts to a @media query instead 😅 We still need to check on the other button styles though. |
Got it 🙂 |
@kirillplatonov - This one is now done.. see #383 for screenshots 🎉 Note: The new Polaris v12 does not have "outline" buttons, so I've silently dropped the class from being added in the component for now, making them a "normal" button:
Not sure if there's a better fallback for these as I don't remember using them anywhere, but let me know if you think it should be done different. |
Button styles need aligning with the new v12 styles. Default and Primary are ok, but we need to check all the other variants.
The text was updated successfully, but these errors were encountered: