Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we start V3? #459

Open
jayelkaake opened this issue Jan 28, 2025 · 1 comment
Open

Can we start V3? #459

jayelkaake opened this issue Jan 28, 2025 · 1 comment

Comments

@jayelkaake
Copy link
Contributor

jayelkaake commented Jan 28, 2025

I've been working with this for the last week pretty heavily and I have a fork which I've started some big improvements that are not reverse-compatible (in addition to a bunch of small ones that are):

  1. Replace deprecated TabsComponent with new TabsComponent.
  2. Update the project structure to centralize all component files in each of their respective locations as specified by view_component-contrib which seems to be taking over the standard.
  3. Update CSS so it isn't scoped to html[class~="Polaris-Summer-Editions-2023"] which makes things harder to style properly since that top level has a high specificity.
  4. Implement rubocop, stylelint, spell-check and other linters so we can keep the code clean with reduced maintenance.

I've also created an automatic dark mode option and made several fixes, but I'll submit those PRs to the main branch.

Can one of the maintainers create a the new branch so we can start on it?

I'd be happy to join as a maintainer BTW. I'm starting a new project with this so I can "battle-test" v3.

@jayelkaake jayelkaake changed the title v3 to follow View Components Standards? Can we start V3? Jan 28, 2025
@kirillplatonov
Copy link
Collaborator

kirillplatonov commented Feb 4, 2025

It's all sounds great! I just created v3 branch for breaking changes. But let's try to merge non breaking changes to main and I will include them in the next minor v2 release.

Update the project structure to centralize all component files in each of their respective locations as specified by view_component-contrib which seems to be taking over the standard.

Can we do it for one component first to try and see if it will be better than current structure? I guess all class names will change too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants