Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPOR protocol #1571

Merged
merged 14 commits into from
Mar 5, 2025
Merged

Add IPOR protocol #1571

merged 14 commits into from
Mar 5, 2025

Conversation

rav-ipor
Copy link
Contributor

Add IPOR Fusion and IPOR Derivatives as one IPOR protocol into Base Ecosystem.

@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 6:00pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 16, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025

@rav-ipor is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@wbnns wbnns added the base ecosystem review This is ecosystem related label Jan 17, 2025
@wbnns
Copy link
Contributor

wbnns commented Jan 17, 2025

@rav-ipor

Thanks for the updated PR! We require that defi apps linked to from base.org include a terms of service / terms and conditions page for users. It doesn't appear that this is present on the linked page. In order to continue the review, could you all please update and let us know?

@wbnns wbnns added the change(s) requested One or more changes have been requested label Jan 17, 2025
@wookash-ipor
Copy link

Hi @wbnns , Thanks for the comment. We have ensured that the Terms of Service is on the production webapp.

@wbnns
Copy link
Contributor

wbnns commented Jan 26, 2025

@rav-ipor

Thanks for the update! Please also update the linked page so that Base is the network that is already selected, for users that would be coming from base.org. 🙏

@rav-ipor
Copy link
Contributor Author

@wbnns the link is changed and now it's pointing directly to IPOR Fusion vaults on Base:
https://app.ipor.io/fusion?chains=8453

@rav-ipor
Copy link
Contributor Author

@wbnns just a friendly reminder about this PR

@rav-ipor
Copy link
Contributor Author

rav-ipor commented Mar 4, 2025

@wbnns once again a friendly reminder about this PR

@wbnns wbnns enabled auto-merge (squash) March 5, 2025 02:38
@wbnns wbnns merged commit 6586e4c into base:master Mar 5, 2025
6 of 7 checks passed
ARYZEofficial pushed a commit to ARYZEofficial/base-web that referenced this pull request Mar 7, 2025
@rav-ipor @beehoneydealer
Add IPOR protocol (base#1571)
3515306 
* Add IPOR Fusion and IPOR Derivatives

* Change imageUrls to SVG files in IPOR protocols

* Change description in IPOR Derivatives protocol

* Change description in IPOR Fusion protocol

* Merge IPOR Fusion and IPOR Derivatives into one IPOR protocol

* Change URL in IPOR project on ecosystem page

* Fix Cyberscope link that was changed unintentionally with merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbnns wbnns wbnns approved these changes

Assignees
No one assigned
Labels
base ecosystem review This is ecosystem related change(s) requested One or more changes have been requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rav-ipor @cb-heimdall @wbnns @wookash-ipor