Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wallet.md into base.org site #1661

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Conversation

cturakhia-cb
Copy link
Contributor

@cturakhia-cb cturakhia-cb commented Jan 28, 2025

What changed? Why?

updated the markdown file for https://docs.base.org/docs/tokens/wallet/

Notes to reviewers
thanks for approving

How has it been tested?
used markdown editors to review

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 10:42pm

Copy link

vercel bot commented Jan 28, 2025

@cturakhia-cb is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 28, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@aflock aflock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images may need to be replaced if they don't resolve better in prod but lgtm otherwise

@brendan-defi brendan-defi merged commit 847bc39 into base:master Jan 29, 2025
5 of 6 checks passed
@cb-heimdall
Copy link
Collaborator

Review Error for brendan-defi @ 2025-01-29 04:11:03 UTC
User failed mfa authentication, see go/mfa-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants