-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: release whole repository #129
Comments
I don't agree. We have been moving towards having both the core rules and the baseline set of tools in this same repository. That will require distinct MODULE.bazel files for the core vs. the others, as core can't depend on anything, while the tools will obviously require language rules. We could create a second project for the tools. That may have other developer costs, since we'll normally want to test in both at once. |
Are the "baseline set of tools" things that are only needed by Bazel users? From my understanding of the tools you have in mind, they would be applicable to developers outside of Bazel who are working with sboms, and therefore I propose that they should not live in rules_license at all. I'd be happy to do the research to find who else is working on tools that accomplish those use cases and make a connection so that we can make sure those tools are easily adoptable by Bazel users as well, or create the tools if they truly don't exist anywhere. |
I think there are two reasons here:
The first reason there isn't a very strong argument for splitting the repository, but the second one definitely is. |
Today, developers must take care to include sources in the
filegroup(name = "standard_package")
targets which are sprinkled around the repository.In the best case, omitting one will be caught by automated testing in the repo. However,
I also claim there is no benefit to having Bazel build the release artifact.
git archive
is completely sufficient for this task (including pruning directories that are unnecessary in the release artifact and which make it large)Making this change would simplify the repository so that it's more feasible for us to maintain it with a very small effort.
The text was updated successfully, but these errors were encountered: