Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change opam packaging to have separate CLI/GUI packages and maybe fsmonitor #842

Closed
gdt opened this issue Dec 2, 2022 · 1 comment · Fixed by #845
Closed

Change opam packaging to have separate CLI/GUI packages and maybe fsmonitor #842

gdt opened this issue Dec 2, 2022 · 1 comment · Fixed by #845
Labels
build issue in unison build system effort-medium issue is likely resolvable with <= 20h of effort enhancement issue is a request for a feature, and not a defect impact-medium medium importance

Comments

@gdt
Copy link
Collaborator

gdt commented Dec 2, 2022

Currently, there is only one opam file. I think it requires gtk3 on the host and builds a CLI, but the point is that one should be able to build CLI or GUI as one wishes.

Somewhere between perhaps and probably, have an opam file for fsmonitor (on the set of platforms for which there is an fsmonitor implementation, with sensible behavior on other ones).

While doing this, align with the unison and unison-gui plan in #667.
@gdt gdt added enhancement issue is a request for a feature, and not a defect impact-medium medium importance build issue in unison build system effort-medium issue is likely resolvable with <= 20h of effort labels Dec 2, 2022
@gdt gdt mentioned this issue Dec 2, 2022
Closed
@gdt
Copy link
Collaborator Author

gdt commented Dec 2, 2022

PR #671 is related.

(My bias is to tread carefully rather than quickly here, but I aim to resolve it all before 2.53.1.)

@jhjourdan jhjourdan mentioned this issue Dec 14, 2022
Merged
@gdt gdt closed this as completed in #845 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build issue in unison build system effort-medium issue is likely resolvable with <= 20h of effort enhancement issue is a request for a feature, and not a defect impact-medium medium importance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use make as a build system for opam files. jhjourdan/unison
1 participant
@gdt