You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note that we could test different settings for BUILD_SHARED_LIBS, though I do get concerned about the combinatorial explosion of all the possible combinations of tests, both in terms of compute per commit pushed but also in terms of the amount of complexity in the GitHub actions configuration.
Problem
Beman libraries currently hardcode
STATIC
in theiradd_library
calls. This is:BUILD_SHARED_LIBS
Proposal
In
[CMAKE.LIBRARY_NAME]
, change this:To this:
add_library(beman.smart_pointer)
Further, require the latter style with justification as outlined in the "Problem" section of this issue.
Reference
For
add_library
supportingBUILD_SHARED_LIBS
:https://cmake.org/cmake/help/latest/command/add_library.html
Docs for
BUILD_SHARED_LIBS
, including thatSTATIC
is the default for CMake built libraries.https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html#variable:BUILD_SHARED_LIBS
A PR to the Beman Exemplar to apply the relevant one-line change:
See bemanproject/exemplar#104.
The text was updated successfully, but these errors were encountered: