Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend find_package #98

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Recommend find_package #98

wants to merge 1 commit into from

Conversation

bretbrownjr
Copy link
Contributor

  • Recommend find_package instead of FetchContent for CMake projects.

  • Retitle [CMAKE.USE_FETCH_CONTENT] to [CMAKE.USE_FIND_PACKAGE]

  • Update examples

@bretbrownjr
Recommend find_package
26e313a 
* Recommend `find_package` instead of `FetchContent` for CMake
projects.

* Retitle `[CMAKE.USE_FETCH_CONTENT]` to `[CMAKE.USE_FIND_PACKAGE]`

* Update examples
@bretbrownjr bretbrownjr mentioned this pull request Feb 17, 2025
Open
@bretbrownjr bretbrownjr marked this pull request as ready for review February 23, 2025 18:00
@bretbrownjr
Copy link
Contributor Author

@camio Given our discussion at the meeting on Feb 17, I think this is ready for a full review.

JeffGarland
JeffGarland approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@JeffGarland JeffGarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the meeting, but it looks like we made a path forward. I don't see any issues here. Approving

@RaduNichita RaduNichita self-requested a review February 24, 2025 13:47
@neatudarius
Copy link
Member

@bretbrownjr , I think we are good to go with this PR. Feel free to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffGarland JeffGarland JeffGarland approved these changes

@neatudarius neatudarius neatudarius approved these changes

@RaduNichita RaduNichita RaduNichita approved these changes

@camio camio Awaiting requested review from camio camio is a code owner

@dietmarkuehl dietmarkuehl Awaiting requested review from dietmarkuehl dietmarkuehl is a code owner

@inbal2l inbal2l Awaiting requested review from inbal2l inbal2l is a code owner

@steve-downey steve-downey Awaiting requested review from steve-downey steve-downey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bretbrownjr @neatudarius @JeffGarland @RaduNichita