-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Optional26 Packageable #28
Comments
Hello @bretbrownjr !
I propose to discuss on Monday in the Beman sync. I think we should have an unified approach (including scripts, CI jobs) for releases in Beman Project. Do we have a script or a CI job for Beman.Example?
I created #29 29. Does this help as an intial step? |
@bretbrownjr , #29 was merged. I think we need to update the issue description. |
I attempted to add Optional26 to the Conan local recipe index I am finishing up in bemanproject/beman#21.
Two problems (so far):
googletest
are vendored into the repo via git submodule workflowsThe first issue can be fairly trivially resolved by clicking using the release feature in the github.com web UI and cutting a release. Of course, an established process and even CI for this task would be great, including developing patterns and CI scripts that other beman projects could benefit from.
The second issue could be a matter of making the relevant
add_subdirectory
conditional somehow, usingfind_package
workflows instead and addinggoogletest
as a package dependency in Conan to ensure it's available to build against. It's also possible that usingFetchContent
instead of git-submodules would make the packaging "work", but Conan is designed such that it does source code indexing and fetching, so I would prefer to adhere to that design when using Conan.The text was updated successfully, but these errors were encountered: