Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Optional26 Packageable #28

Open
2 tasks
bretbrownjr opened this issue Jun 28, 2024 · 2 comments
Open
2 tasks

Make Optional26 Packageable #28

bretbrownjr opened this issue Jun 28, 2024 · 2 comments

Comments

@bretbrownjr
Copy link

I attempted to add Optional26 to the Conan local recipe index I am finishing up in bemanproject/beman#21.

Two problems (so far):

  • Optional26 needs tarball and/or zip releases.
  • Optional26 uses CMakeLists.txt that assumes dependencies, at least googletest are vendored into the repo via git submodule workflows

The first issue can be fairly trivially resolved by clicking using the release feature in the github.com web UI and cutting a release. Of course, an established process and even CI for this task would be great, including developing patterns and CI scripts that other beman projects could benefit from.

The second issue could be a matter of making the relevant add_subdirectory conditional somehow, using find_package workflows instead and adding googletest as a package dependency in Conan to ensure it's available to build against. It's also possible that using FetchContent instead of git-submodules would make the packaging "work", but Conan is designed such that it does source code indexing and fetching, so I would prefer to adhere to that design when using Conan.

@neatudarius
Copy link
Member

neatudarius commented Jun 29, 2024

Hello @bretbrownjr !

The first issue can be fairly trivially resolved by clicking using the release feature in the github.com web UI and cutting a release. Of course, an established process and even CI for this task would be great, including developing patterns and CI scripts that other beman projects could benefit from.

I propose to discuss on Monday in the Beman sync. I think we should have an unified approach (including scripts, CI jobs) for releases in Beman Project. Do we have a script or a CI job for Beman.Example?

The second issue could be a matter of making the relevant add_subdirectory conditional somehow, using find_package workflows instead and adding googletest as a package dependency in Conan to ensure it's available to build against. It's also possible that using FetchContent instead of git-submodules would make the packaging "work", but Conan is designed such that it does source code indexing and fetching, so I would prefer to adhere to that design when using Conan.

I created #29 29. Does this help as an intial step?

@neatudarius
Copy link
Member

@bretbrownjr , #29 was merged. I think we need to update the issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants