Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ci action to use a matrix of options #33

Open
steve-downey opened this issue Jul 15, 2024 · 1 comment
Open

Refactor ci action to use a matrix of options #33

steve-downey opened this issue Jul 15, 2024 · 1 comment

Comments

@steve-downey
Copy link
Member

Right now the ci.yml specifies a collection of configs to run the matrix build over. It would be better style to set the variables and let CI construct the cartesian product:

    strategy:
      matrix:
        clang-version: [17]
        os: [ubuntu-24.04]
        toolchain: [clang-17-toolchain.cmake, clang-18-toolchain.cmake, gcc-13-toolchain.cmake]
        

https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs

@neatudarius
Copy link
Member

neatudarius commented Jul 16, 2024

Agree that we should improve this.

  • Note that we still have a specific parameter added for clang-19: asan_options: "new_delete_type_mismatch=0" or cmake_config: RelWithDebInfo.
  • Also, it seems that C++26 won't work with gcc-13 (check WIP PR Improve local and CI flows #26).

TLDR: I think we can do a better arrangement here, but I think we still need to have explicit exceptions for some toolchains, so maybe it's OK to have current format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants