Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing value() const && overload #40

Open
jwakely opened this issue Jul 18, 2024 · 2 comments
Open

Missing value() const && overload #40

jwakely opened this issue Jul 18, 2024 · 2 comments
Assignees
@steve-downey

Comments

@jwakely
Copy link

jwakely commented Jul 18, 2024

https://github.com/beman-project/Optional26/blob/bfeb9080c0d9c501965ae857a1decf7ed74686f5/include/Beman/Optional26/optional.hpp#L468-L484

There should be four value() overloads.
@jwakely
Copy link
Author

jwakely commented Jul 18, 2024 •
edited
Loading

Similarly, or_else only has two overloads, not four. Edit: that's correct though!

@jwakely
Copy link
Author

jwakely commented Jul 18, 2024

operator* is missing the const&& overload.

@steve-downey steve-downey self-assigned this Jul 18, 2024
@steve-downey steve-downey mentioned this issue Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steve-downey steve-downey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwakely @steve-downey