New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ascent vehicle launch counts are sourced to the service provider, not the vehicle #65

Open

benetherington opened this issue Aug 21, 2022 · 0 comments

Owner

benetherington commented Aug 21, 2022

const totalLaunchCount =
        launchData.launch_service_provider.total_launch_count;
const consecutiveLaunchCount =
        launchData.launch_service_provider.consecutive_successful_launches;

Should be

const totalLaunchCount =
        launchData.rocket.configuration.total_launch_count;
const consecutiveLaunchCount =
        launchData.rocket.configuration.consecutive_successful_launches;

maybe? This is just for the one configuration, might need a second call to get the vehicle-specific stats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment