Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets with paths not updated in 1.5.0 #218

Open
jsiragusa opened this issue Jan 11, 2017 · 8 comments
Open

Assets with paths not updated in 1.5.0 #218

jsiragusa opened this issue Jan 11, 2017 · 8 comments

Comments

@jsiragusa
Copy link

jsiragusa commented Jan 11, 2017

I was previously using v1.4.1 and when I had an HTML like: <script type="text/javascript" src="assets/app.js"></script>

It would correctly get busted to: <script type="text/javascript" src="assets/app.HASH.js"></script>

I bumped up to 1.5.0 and noticed that the HTML is not updated (output from the task doesn't indicate any errors). However, I noticed if the assets are referenced without a path, they are updated correctly. I.e. <script type="text/javascript" src="app.js"></script> works.

Is this by design? I couldn't find anything in the docs to suggest that assets with a path shouldn't work by default.

@enstyled
Copy link

Having the same issue.

@bastienmoulia
Copy link

Probably a file system issue. @jsiragusa @enstyled are you on Windows?

@jsiragusa
Copy link
Author

OS X for me

@enstyled
Copy link

OS X 10.12.2 here.

@colleen-love
Copy link

Debian 8.7 on Docker here.

@carlotrimarchi
Copy link

I have the same issue on a Mac

@richardhinkamp
Copy link
Contributor

Could anybody test with the fixes in PR #220? If that doesn't fix your setup, could you provide a test cases/config so I can look at it?

@jsiragusa
Copy link
Author

@richardhinkamp apologies for the delay. It was some time until I could get back on this project. I tested your PR and, unfortunately it didn't help my issue. However, I began to examine the changes in your PR and well as the commit (0c69b17) that I believe introduced the problem and I discovered that it's how the assets are treated.

My original config (which worked fine in v.1.4.1):

        options: {
          baseDir: '<%= build_dir %>/assets/',
          assets: ['*.js', '*.css']
        }

Adjusted config which now works with v1.5.0

        options: {
          baseDir: '<%= build_dir %>/',
          assets: ['assets/**.js', 'assets/**.css']
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants